From: Joel Granados <j.granados@samsung•com>
To: Dan Carpenter <dan.carpenter@linaro•org>
Cc: <mcgrof@kernel•org>, Jason Gunthorpe <jgg@ziepe•ca>,
Leon Romanovsky <leon@kernel•org>,
David Ahern <dsahern@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Joerg Reuter <jreuter@yaina•de>,
Ralf Baechle <ralf@linux-mips•org>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
"Florian Westphal" <fw@strlen•de>,
Roopa Prabhu <roopa@nvidia•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Alexander Aring <alex.aring@gmail•com>,
Stefan Schmidt <stefan@datenfreihafen•org>,
Miquel Raynal <miquel.raynal@bootlin•com>,
Steffen Klassert <steffen.klassert@secunet•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Matthieu Baerts <matthieu.baerts@tessares•net>,
Mat Martineau <martineau@kernel•org>,
"Simon Horman" <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
"Remi Denis-Courmont" <courmisch@gmail•com>,
Santosh Shilimkar <santosh.shilimkar@oracle•com>,
David Howells <dhowells@redhat•com>,
"Marc Dionne" <marc.dionne@auristor•com>,
Neil Horman <nhorman@tuxdriver•com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>,
Xin Long <lucien.xin@gmail•com>,
Karsten Graul <kgraul@linux•ibm.com>,
Wenjia Zhang <wenjia@linux•ibm.com>,
Jan Karcher <jaka@linux•ibm.com>, Jon Maloy <jmaloy@redhat•com>,
Ying Xue <ying.xue@windriver•com>,
Martin Schiller <ms@dev•tdt.de>, <linux-rdma@vger•kernel.org>,
<linux-kernel@vger•kernel.org>, <netdev@vger•kernel.org>,
<linux-hams@vger•kernel.org>, <netfilter-devel@vger•kernel.org>,
<coreteam@netfilter•org>, <bridge@lists•linux-foundation.org>,
<dccp@vger•kernel.org>, <linux-wpan@vger•kernel.org>,
<mptcp@lists•linux.dev>, <lvs-devel@vger•kernel.org>,
<rds-devel@oss•oracle.com>, <linux-afs@lists•infradead.org>,
<linux-sctp@vger•kernel.org>, <linux-s390@vger•kernel.org>,
<tipc-discussion@lists•sourceforge.net>,
<linux-x25@vger•kernel.org>
Subject: Re: [PATCH 06/11] sysctl: Add size to register_net_sysctl function
Date: Wed, 21 Jun 2023 13:49:27 +0200 [thread overview]
Message-ID: <20230621114927.woeidgxx5jhtchxt@localhost> (raw)
In-Reply-To: <f95b7489-8654-435c-bc74-da1eac479fba@kadam.mountain>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On Wed, Jun 21, 2023 at 01:49:54PM +0300, Dan Carpenter wrote:
> On Wed, Jun 21, 2023 at 12:47:30PM +0300, Dan Carpenter wrote:
> > The patchset doesn't include the actual interesting changes, just a
> > bunch of mechanical prep work.
> >
>
> I was wrong here, the patchset just hadn't all hit the mailing lists.
not even. It was that the patch got mangled by some error on my side.
> I can't apply this patchset to anything. I tried linux-next, net, and
> net-next. So it's hard to review.
All this applies cleanly to mcgrof's sysctl-next branch here
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next
>
> It looks like ensure_safe_net_sysctl() never got update to use
> table_size...
Done. I realized this while checking out your other comments. thx.
>
> You could easily write a static checker test to print a warning any time
> that ->procname is checked for NULL. I have attached a Smatch check.
> You would need to added to check_list.h and recompile.
Awesome!!!, I had been doing this with coccinelle, I'll recompile with
smatch and see if I get extra hits. Thx!
>
> net/sysctl_net.c:130 ensure_safe_net_sysctl() warn: checking ->procname 'ent->procname'
Done. Will be available in V2
>
> regards,
> dan carpenter
>
Best
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-06-21 11:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230621091014eucas1p1a30430568d0f7fec5ccbed31cab73aa0@eucas1p1.samsung.com>
[not found] ` <20230621091000.424843-1-j.granados@samsung.com>
2023-06-21 9:09 ` [PATCH 05/11] sysctl: Add a size arg to __register_sysctl_table Joel Granados
2023-06-21 20:53 ` Jakub Kicinski
2023-06-22 14:09 ` Joel Granados
2023-06-21 9:09 ` [PATCH 06/11] sysctl: Add size to register_net_sysctl function Joel Granados
2023-06-21 9:47 ` Dan Carpenter
2023-06-21 10:23 ` Dan Carpenter
2023-06-21 12:03 ` Joel Granados
2023-06-23 14:21 ` Joel Granados
2023-06-21 10:49 ` Dan Carpenter
2023-06-21 11:49 ` Joel Granados [this message]
2023-06-21 11:36 ` Joel Granados
2023-06-21 9:09 ` [PATCH 07/11] sysctl: Add size to register_sysctl Joel Granados
2023-06-21 9:48 ` [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays Joel Granados
2023-06-21 11:16 ` Jani Nikula
2023-06-21 13:06 ` Joel Granados
2023-06-21 13:15 ` Jani Nikula
2023-06-21 13:43 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621114927.woeidgxx5jhtchxt@localhost \
--to=j.granados@samsung$(echo .)com \
--cc=alex.aring@gmail$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=coreteam@netfilter$(echo .)org \
--cc=courmisch@gmail$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dccp@vger$(echo .)kernel.org \
--cc=dhowells@redhat$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=jaka@linux$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jmaloy@redhat$(echo .)com \
--cc=jreuter@yaina$(echo .)de \
--cc=kadlec@netfilter$(echo .)org \
--cc=kgraul@linux$(echo .)ibm.com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=linux-x25@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=marc.dionne@auristor$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=martineau@kernel$(echo .)org \
--cc=matthieu.baerts@tessares$(echo .)net \
--cc=mcgrof@kernel$(echo .)org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=ms@dev$(echo .)tdt.de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=razor@blackwall$(echo .)org \
--cc=rds-devel@oss$(echo .)oracle.com \
--cc=roopa@nvidia$(echo .)com \
--cc=santosh.shilimkar@oracle$(echo .)com \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=wenjia@linux$(echo .)ibm.com \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox