From: Lee Jones <lee@kernel•org>
To: Christian Marangi <ansuelsmth@gmail•com>
Cc: Pavel Machek <pavel@ucw•cz>, Andrew Lunn <andrew@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Dan Carpenter <dan.carpenter@linaro•org>,
linux-leds@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [net-next PATCH v5 2/3] leds: trigger: netdev: add additional specific link duplex mode
Date: Wed, 21 Jun 2023 15:55:12 +0100 [thread overview]
Message-ID: <20230621145512.GB10378@google.com> (raw)
In-Reply-To: <20230619204700.6665-3-ansuelsmth@gmail.com>
On Mon, 19 Jun 2023, Christian Marangi wrote:
> Add additional modes for specific link duplex. Use ethtool APIs to get the
> current link duplex and enable the LED accordingly. Under netdev event
> handler the rtnl lock is already held and is not needed to be set to
> access ethtool APIs.
>
> This is especially useful for PHY and Switch that supports LEDs hw
> control for specific link duplex.
>
> Add additional modes:
> - half_duplex: Turn on LED when link is half duplex
> - full_duplex: Turn on LED when link is full duplex
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail•com>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
> ---
> drivers/leds/trigger/ledtrig-netdev.c | 27 +++++++++++++++++++++++++--
> include/linux/leds.h | 2 ++
> 2 files changed, 27 insertions(+), 2 deletions(-)
Acked-by: Lee Jones <lee@kernel•org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-21 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 20:46 [net-next PATCH v5 0/3] leds: trigger: netdev: add additional modes Christian Marangi
2023-06-19 20:46 ` [net-next PATCH v5 1/3] leds: trigger: netdev: add additional specific link speed mode Christian Marangi
2023-06-21 14:54 ` Lee Jones
2023-06-19 20:46 ` [net-next PATCH v5 2/3] leds: trigger: netdev: add additional specific link duplex mode Christian Marangi
2023-06-21 14:55 ` Lee Jones [this message]
2023-06-19 20:47 ` [net-next PATCH v5 3/3] leds: trigger: netdev: expose hw_control status via sysfs Christian Marangi
2023-06-20 3:50 ` Kalesh Anakkur Purayil
2023-06-20 13:21 ` Andrew Lunn
2023-06-20 14:25 ` Kalesh Anakkur Purayil
2023-06-21 14:55 ` Lee Jones
2023-06-21 22:10 ` [net-next PATCH v5 0/3] leds: trigger: netdev: add additional modes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621145512.GB10378@google.com \
--to=lee@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox