Subject: Re: [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err

From: Jakub Kicinski <[email-masked]>
Date: Sat, 24 Jun 2023 15:19:11 -0700

On Thu, 22 Jun 2023 14:03:32 -0500 Nick Child wrote:
> +		if (adapter->reset_reason == VNIC_RESET_NON_FATAL)
> +			clear_bit(__QUEUE_STATE_STACK_XOFF,
> +				  &netdev_get_tx_queue(netdev, i)->state);

Why are you trying to clear this bit?

If the completions will still come the bit will be cleared (or not)
during completion handling (netdev_tx_completed_queue() et al.)

Drivers shouldn't be poking into queue state bits directly.
-- 
pw-bot: cr