Subject: Re: [PATCH net-next v3] net: ngbe: add Wake on Lan support

From: Jakub Kicinski <[email-masked]>
Date: Mon, 26 Jun 2023 13:17:57 -0700

On Mon, 26 Jun 2023 16:37:08 +0800 Mengyuan Lou wrote:
> +	if (!wx->wol_hw_supported)
> +		return -EOPNOTSUPP;
> +	if (!(wol->wolopts & WAKE_MAGIC) &&
> +	    wol->wolopts != 0)
> +		return -EOPNOTSUPP;

AFAIK core (by which I mean net/ethtool/* code) already checks that
bits outside of ->supported are not set in wolopts.

Please post v4 after the merge window (in 2 weeks)
-- 
pw-bot: cr