Subject: Re: tc.8: some remarks and a patch for the manual

From: Stephen Hemminger <[email-masked]>
Date: Tue, 27 Jun 2023 10:38:49 -0700

On Sat, 24 Jun 2023 21:43:21 +0000
Bjarni Ingi Gislason <[email-masked]> wrote:

> Package: iproute2
> Version: 6.3.0
> Severity: minor
> Tags: patch
> 
> Dear Maintainer,
> 
> here are some notes and a patch.
> 
> The difference between the formatted outputs can be seen with:
> 
>   nroff -man <file1> > <out1>
>   nroff -man <file2> > <out2>
>   diff -u <out1> <out2>
> 
> and for groff, using
> 
> "groff -man -Z" instead of "nroff -man"

Overall this looks fine but:
1. Make the commit message more succinct and clearer, don't need to write a letter.
2. Lines with starting with # get ignored by git when committing
3. Missing Signed-Off-by which is required for all iproute2 patches.

Running checkpatch on this patch will show these things.