From: Gavin Li <gavinl@nvidia•com>
To: <mst@redhat•com>, <jasowang@redhat•com>,
<xuanzhuo@linux•alibaba.com>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<ast@kernel•org>, <daniel@iogearbox•net>, <hawk@kernel•org>,
<john.fastabend@gmail•com>, <jiri@nvidia•com>,
<dtatulea@nvidia•com>
Cc: <virtualization@lists•linux-foundation.org>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<bpf@vger•kernel.org>
Subject: [PATCH net-next V1 4/4] virtio_net: enable per queue interrupt coalesce feature
Date: Mon, 10 Jul 2023 12:20:05 +0300 [thread overview]
Message-ID: <20230710092005.5062-5-gavinl@nvidia.com> (raw)
In-Reply-To: <20230710092005.5062-1-gavinl@nvidia.com>
Enable per queue interrupt coalesce feature bit in driver and validate its
dependency with control queue.
Signed-off-by: Gavin Li <gavinl@nvidia•com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia•com>
Reviewed-by: Jiri Pirko <jiri@nvidia•com>
---
drivers/net/virtio_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 333a38e1941f..81bac3597a2b 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -4060,6 +4060,8 @@ static bool virtnet_validate_features(struct virtio_device *vdev)
VIRTNET_FAIL_ON(vdev, VIRTIO_NET_F_HASH_REPORT,
"VIRTIO_NET_F_CTRL_VQ") ||
VIRTNET_FAIL_ON(vdev, VIRTIO_NET_F_NOTF_COAL,
+ "VIRTIO_NET_F_CTRL_VQ") ||
+ VIRTNET_FAIL_ON(vdev, VIRTIO_NET_F_VQ_NOTF_COAL,
"VIRTIO_NET_F_CTRL_VQ"))) {
return false;
}
@@ -4484,6 +4486,7 @@ static struct virtio_device_id id_table[] = {
VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \
VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY, \
VIRTIO_NET_F_RSS, VIRTIO_NET_F_HASH_REPORT, VIRTIO_NET_F_NOTF_COAL, \
+ VIRTIO_NET_F_VQ_NOTF_COAL, \
VIRTIO_NET_F_GUEST_HDRLEN
static unsigned int features[] = {
--
2.39.1
next prev parent reply other threads:[~2023-07-10 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:20 [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support Gavin Li
2023-07-10 9:20 ` [PATCH net-next V1 1/4] virtio_net: extract interrupt coalescing settings to a structure Gavin Li
2023-07-10 9:20 ` [PATCH net-next V1 2/4] virtio_net: extract get/set interrupt coalesce to a function Gavin Li
2023-07-10 9:20 ` [PATCH net-next V1 3/4] virtio_net: support per queue interrupt coalesce command Gavin Li
2023-07-12 9:39 ` Xuan Zhuo
2023-07-12 9:44 ` Gavin Li
2023-07-10 9:20 ` Gavin Li [this message]
2023-07-10 9:25 ` [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support Xuan Zhuo
2023-07-11 2:34 ` Gavin Li
2023-07-11 3:10 ` Xuan Zhuo
2023-07-12 8:34 ` Heng Qi
2023-07-13 2:22 ` Gavin Li
2023-07-13 11:40 ` Michael S. Tsirkin
2023-07-14 2:10 ` Xuan Zhuo
2023-08-30 19:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710092005.5062-5-gavinl@nvidia.com \
--to=gavinl@nvidia$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox