From: Jakub Kicinski <kuba@kernel•org>
To: Abel Wu <wuyun.abel@bytedance•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Johannes Weiner <hannes@cmpxchg•org>,
Michal Hocko <mhocko@kernel•org>,
Roman Gushchin <roman.gushchin@linux•dev>,
Shakeel Butt <shakeelb@google•com>,
Muchun Song <muchun.song@linux•dev>,
Andrew Morton <akpm@linux-foundation•org>,
David Ahern <dsahern@kernel•org>,
Yosry Ahmed <yosryahmed@google•com>,
"Matthew Wilcox (Oracle)" <willy@infradead•org>,
Yu Zhao <yuzhao@google•com>,
Kefeng Wang <wangkefeng.wang@huawei•com>,
Yafang Shao <laoar.shao@gmail•com>,
Kuniyuki Iwashima <kuniyu@amazon•com>,
Martin KaFai Lau <martin.lau@kernel•org>,
Alexander Mikhalitsyn <alexander@mihalicyn•com>,
Breno Leitao <leitao@debian•org>,
David Howells <dhowells@redhat•com>,
Jason Xing <kernelxing@tencent•com>,
Xin Long <lucien.xin@gmail•com>, Michal Hocko <mhocko@suse•com>,
Alexei Starovoitov <ast@kernel•org>,
linux-kernel@vger•kernel.org (open list),
netdev@vger•kernel.org (open list:NETWORKING [GENERAL]),
cgroups@vger•kernel.org (open list:CONTROL GROUP - MEMORY
RESOURCE CONTROLLER (MEMCG)),
linux-mm@kvack•org (open list:CONTROL GROUP - MEMORY RESOURCE
CONTROLLER (MEMCG))
Subject: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure
Date: Tue, 11 Jul 2023 20:45:37 -0700 [thread overview]
Message-ID: <20230711204537.04cb1124@kernel.org> (raw)
In-Reply-To: <20230711124157.97169-1-wuyun.abel@bytedance.com>
On Tue, 11 Jul 2023 20:41:43 +0800 Abel Wu wrote:
> Now there are two indicators of socket memory pressure sit inside
> struct mem_cgroup, socket_pressure and tcpmem_pressure.
>
> When in legacy mode aka. cgroupv1, the socket memory is charged
> into a separate counter memcg->tcpmem rather than ->memory, so
> the reclaim pressure of the memcg has nothing to do with socket's
> pressure at all. While for default mode, the ->tcpmem is simply
> not used.
>
> So {socket,tcpmem}_pressure are only used in default/legacy mode
> respectively. This patch fixes the pieces of code that make mixed
> use of both.
Eric Dumazet is currently AFK, can we wait for him to return
(in about a week) before merging?
next prev parent reply other threads:[~2023-07-12 3:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 12:41 [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Abel Wu
2023-07-11 12:41 ` [PATCH RESEND net-next 2/2] net-memcg: Remove redundant tcpmem_pressure Abel Wu
2023-07-12 3:45 ` Jakub Kicinski [this message]
2023-07-12 6:45 ` Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Abel Wu
2023-07-20 7:58 ` Abel Wu
2023-07-20 8:57 ` Eric Dumazet
2023-07-20 11:34 ` Abel Wu
2023-07-22 0:20 ` Roman Gushchin
2023-07-24 3:47 ` Abel Wu
2023-07-26 2:56 ` Roman Gushchin
2023-07-26 8:44 ` Abel Wu
2023-07-27 0:19 ` Roman Gushchin
2023-07-28 12:45 ` Abel Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711204537.04cb1124@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander@mihalicyn$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=kernelxing@tencent$(echo .)com \
--cc=kuniyu@amazon$(echo .)com \
--cc=laoar.shao@gmail$(echo .)com \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=martin.lau@kernel$(echo .)org \
--cc=mhocko@kernel$(echo .)org \
--cc=mhocko@suse$(echo .)com \
--cc=muchun.song@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=roman.gushchin@linux$(echo .)dev \
--cc=shakeelb@google$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=willy@infradead$(echo .)org \
--cc=wuyun.abel@bytedance$(echo .)com \
--cc=yosryahmed@google$(echo .)com \
--cc=yuzhao@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox