Subject: Re: [PATCH net-next 1/2] xfrm: add the description of CHACHA20-POLY1305 for xfrm algorithm description

From: Leon Romanovsky <[email-masked]>
Date: Wed, 19 Jul 2023 12:35:09 +0300

On Wed, Jul 19, 2023 at 11:27:27AM +0200, Steffen Klassert wrote:
> On Wed, Jul 19, 2023 at 11:18:29AM +0200, Louis Peens wrote:
> > From: Shihong Wang <[email-masked]>
> > 
> > Add the description of CHACHA20-POLY1305 for xfrm algorithm description
> > and set pfkey_supported to 1 so that xfrm supports that the algorithm
> > can be offloaded to the NIC.
> > 
> > Signed-off-by: Shihong Wang <[email-masked]>
> > Acked-by: Simon Horman <[email-masked]>
> > Signed-off-by: Louis Peens <[email-masked]>
> > ---
> >  include/uapi/linux/pfkeyv2.h | 1 +
> >  net/xfrm/xfrm_algo.c         | 9 ++++++++-
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/uapi/linux/pfkeyv2.h b/include/uapi/linux/pfkeyv2.h
> > index 8abae1f6749c..d0ab530e1069 100644
> > --- a/include/uapi/linux/pfkeyv2.h
> > +++ b/include/uapi/linux/pfkeyv2.h
> > @@ -331,6 +331,7 @@ struct sadb_x_filter {
> >  #define SADB_X_EALG_CAMELLIACBC		22
> >  #define SADB_X_EALG_NULL_AES_GMAC	23
> >  #define SADB_X_EALG_SM4CBC		24
> > +#define SADB_X_EALG_CHACHA20_POLY1305	25
> 
> Please don't add new stuff to pfkey, use netlink instead. This interface
> is deprecated and will go away someday

Steffen, I have general questions.
>From where did all these SADB_X_EALG_* values come?
And there are they used?

As an exercise, I checked SADB_X_EALG_SM4CBC usage in github and didn't
find anything.
https://github.com/search?q=SADB_X_EALG_SM4CBC&type=code

Thanks