Subject: Re: [PATCH net v3 1/1] mlxbf_gige: Fix kernel panic at shutdown

From: Jakub Kicinski <[email-masked]>
Date: Thu, 20 Jul 2023 20:21:32 -0700

On Thu, 20 Jul 2023 21:11:53 +0000 Asmaa Mnebhi wrote:
> >  	.probe = mlxbf_gige_probe,
> >  	.remove = mlxbf_gige_remove,
> > -	.shutdown = mlxbf_gige_shutdown,
> > +	.shutdown = mlxbf_gige_remove,  
> 
> Actually, apologies for this commit in response to Sridhar's comment
> on v2. This will not work. Mlxbf_gige_remove() returns void while
> ".shutdown" expects to return an int. Please advise on how to
> proceed. Should I send a v4 with the same patch as v2?

You can make it work, there is a new version of remove upstream:

https://elixir.bootlin.com/linux/v6.5-rc2/source/include/linux/platform_device.h#L220

You can make them both void.
-- 
pw-bot: cr