From: Jakub Kicinski <kuba@kernel•org>
To: Edward Cree <ecree.xilinx@gmail•com>
Cc: Joe Damato <jdamato@fastly•com>,
netdev@vger•kernel.org, saeedm@nvidia•com, tariqt@nvidia•com,
ecree@solarflare•com, andrew@lunn•ch, davem@davemloft•net,
leon@kernel•org, pabeni@redhat•com, bhutchings@solarflare•com,
arnd@arndb•de, linux-kernel@vger•kernel.org
Subject: Re: [net 0/2] rxfh with custom RSS fixes
Date: Mon, 24 Jul 2023 15:08:15 -0700 [thread overview]
Message-ID: <20230724150815.494ae294@kernel.org> (raw)
In-Reply-To: <b52f55ef-f166-cd1a-85b5-5fe32fe5f525@gmail.com>
On Mon, 24 Jul 2023 20:27:43 +0100 Edward Cree wrote:
> On 23/07/2023 16:06, Joe Damato wrote:
> > Greetings:
> >
> > While attempting to get the RX flow hash key for a custom RSS context on
> > my mlx5 NIC, I got an error:
> >
> > $ sudo ethtool -u eth1 rx-flow-hash tcp4 context 1
> > Cannot get RX network flow hashing options: Invalid argument
> >
> > I dug into this a bit and noticed two things:
> >
> > 1. ETHTOOL_GRXFH supports custom RSS contexts, but ETHTOOL_SRXFH does
> > not. I moved the copy logic out of ETHTOOL_GRXFH and into a helper so
> > that both ETHTOOL_{G,S}RXFH now call it, which fixes ETHTOOL_SRXFH. This
> > is patch 1/2.
>
> As I see it, this is a new feature, not a fix, so belongs on net-next.
> (No existing driver accepts FLOW_RSS in ETHTOOL_SRXFH's cmd->flow_type,
> which is just as well as if they did this would be a uABI break.)
>
> Going forward, ETHTOOL_SRXFH will hopefully be integrated into the new
> RSS context kAPI I'm working on[1], so that we can have a new netlink
> uAPI for RSS configuration that's all in one place instead of the
> piecemeal-grown ethtool API with its backwards-compatible hacks.
> But that will take a while, so I think this should go in even though
> it's technically an extension to legacy ethtool; it was part of the
> documented uAPI and userland implements it, it just never got
> implemented on the kernel side (because the initial driver with
> context support, sfc, didn't support SRXFH).
What's the status on your work? Are you planning to split the RSS
config from ethtool or am I reading too much into what you said?
It'd be great to push the uAPI extensions back and make them
netlink-only, but we can't make Joe wait if it takes a long time
to finish up the basic conversion :(
next prev parent reply other threads:[~2023-07-24 22:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 15:06 [net 0/2] rxfh with custom RSS fixes Joe Damato
2023-07-23 15:06 ` [net 1/2] net: ethtool: Unify ETHTOOL_{G,S}RXFH rxnfc copy Joe Damato
2023-07-24 19:27 ` Edward Cree
2023-07-23 15:06 ` [net 2/2] net/mlx5: Fix flowhash key set/get for custom RSS Joe Damato
2023-07-25 9:59 ` Tariq Toukan
2023-07-26 8:28 ` Joe Damato
2023-07-24 19:27 ` [net 0/2] rxfh with custom RSS fixes Edward Cree
2023-07-24 21:36 ` Joe Damato
2023-07-24 22:08 ` Jakub Kicinski [this message]
2023-07-25 8:40 ` Edward Cree
2023-07-25 20:47 ` Joe Damato
2023-07-27 15:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724150815.494ae294@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=ecree@solarflare$(echo .)com \
--cc=jdamato@fastly$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox