From: Kees Cook <keescook@chromium•org>
To: Kuniyuki Iwashima <kuniyu@amazon•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
Breno Leitao <leitao@debian•org>,
Kuniyuki Iwashima <kuni1840@gmail•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH v3 net 0/2] net: Fix error/warning by -fstrict-flex-arrays=3.
Date: Tue, 25 Jul 2023 11:05:21 -0700 [thread overview]
Message-ID: <202307251104.74C96AF830@keescook> (raw)
In-Reply-To: <20230724213425.22920-1-kuniyu@amazon.com>
On Mon, Jul 24, 2023 at 02:34:23PM -0700, Kuniyuki Iwashima wrote:
> df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") started applying
> strict rules for standard string functions (strlen(), memcpy(), etc.) if
> CONFIG_FORTIFY_SOURCE=y.
>
> This series fixes two false positives caught by syzkaller.
>
>
> Changes:
> v3:
> * Drop Reviewed-by
> * Patch 1: Use strnlen()
> * Patch 2: Add a new flex array member
>
> v2: https://lore.kernel.org/netdev/20230720004410.87588-1-kuniyu@amazon.com/
> * Patch 2: Fix offset calc.
>
> v1: https://lore.kernel.org/netdev/20230719185322.44255-1-kuniyu@amazon.com/
>
>
> Kuniyuki Iwashima (2):
> af_unix: Fix fortify_panic() in unix_bind_bsd().
> af_packet: Fix warning of fortified memcpy() in packet_getname().
>
> include/uapi/linux/if_packet.h | 6 +++++-
> net/packet/af_packet.c | 2 +-
> net/unix/af_unix.c | 6 ++----
> 3 files changed, 8 insertions(+), 6 deletions(-)
>
> --
> 2.30.2
>
Thanks for updating and testing!
Reviewed-by: Kees Cook <keescook@chromium•org>
--
Kees Cook
next prev parent reply other threads:[~2023-07-25 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 21:34 [PATCH v3 net 0/2] net: Fix error/warning by -fstrict-flex-arrays=3 Kuniyuki Iwashima
2023-07-24 21:34 ` [PATCH v3 net 1/2] af_unix: Fix fortify_panic() in unix_bind_bsd() Kuniyuki Iwashima
2023-07-26 13:52 ` kernel test robot
2023-07-26 16:19 ` Kuniyuki Iwashima
2023-07-26 22:02 ` Kees Cook
2023-07-24 21:34 ` [PATCH v3 net 2/2] af_packet: Fix warning of fortified memcpy() in packet_getname() Kuniyuki Iwashima
2023-07-25 17:25 ` [PATCH v3 net 0/2] net: Fix error/warning by -fstrict-flex-arrays=3 Simon Horman
2023-07-25 18:05 ` Kees Cook [this message]
2023-07-26 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307251104.74C96AF830@keescook \
--to=keescook@chromium$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuni1840@gmail$(echo .)com \
--cc=kuniyu@amazon$(echo .)com \
--cc=leitao@debian$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox