Subject: Re: [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics

From: Jakub Kicinski <[email-masked]>
Date: Tue, 25 Jul 2023 16:22:34 -0700

On Mon, 24 Jul 2023 17:24:58 +0800 Mengyuan Lou wrote:
> +	netdev->ncsi_enabled = wx->ncsi_hw_supported;

I don't think that enabled and supported are the same thing.
If server has multiple NICs or a NIC with multiple ports and
BMC only uses one, or even none, we shouldn't keep the PHY up.
By that logic 99% of server NICs should report NCSI as enabled.