From: kernel test robot <lkp@intel•com>
To: Shenwei Wang <shenwei.wang@nxp•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Shawn Guo <shawnguo@kernel•org>,
NXP Linux Team <linux-imx@nxp•com>,
Russell King <linux@armlinux•org.uk>
Cc: oe-kbuild-all@lists•linux.dev, netdev@vger•kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Jose Abreu <joabreu@synopsys•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, imx@lists•linux.dev,
Shenwei Wang <shenwei.wang@nxp•com>, Frank Li <frank.li@nxp•com>
Subject: Re: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link
Date: Wed, 26 Jul 2023 07:23:44 +0800 [thread overview]
Message-ID: <202307260736.EE13gy3b-lkp@intel.com> (raw)
In-Reply-To: <20230725194931.1989102-1-shenwei.wang@nxp.com>
Hi Shenwei,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on net-next/main net/main linus/master v6.5-rc3 next-20230725]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shenwei-Wang/net-stmmac-dwmac-imx-pause-the-TXC-clock-in-fixed-link/20230726-035218
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20230725194931.1989102-1-shenwei.wang%40nxp.com
patch subject: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230726/202307260736.EE13gy3b-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230726/202307260736.EE13gy3b-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel•com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307260736.EE13gy3b-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c: In function 'imx_dwmac_fix_speed_mx93':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c:240:38: warning: variable 'plat_dat' set but not used [-Wunused-but-set-variable]
240 | struct plat_stmmacenet_data *plat_dat;
| ^~~~~~~~
vim +/plat_dat +240 drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
237
238 static void imx_dwmac_fix_speed_mx93(void *priv, unsigned int speed)
239 {
> 240 struct plat_stmmacenet_data *plat_dat;
241 struct imx_priv_data *dwmac = priv;
242 int val, ctrl, old_ctrl;
243
244 imx_dwmac_fix_speed(priv, speed);
245
246 old_ctrl = readl(dwmac->base_addr + MAC_CTRL_REG);
247 plat_dat = dwmac->plat_dat;
248 ctrl = old_ctrl & ~CTRL_SPEED_MASK;
249
250 /* by default ctrl will be SPEED_1000 */
251 if (speed == SPEED_100)
252 ctrl |= RMII_RESET_SPEED;
253 if (speed == SPEED_10)
254 ctrl |= TEN_BASET_RESET_SPEED;
255
256 if (imx_dwmac_is_fixed_link(dwmac)) {
257 writel(ctrl, dwmac->base_addr + MAC_CTRL_REG);
258
259 /* Ensure the settings for CTRL are applied */
260 wmb();
261
262 val = MX93_GPR_ENET_QOS_INTF_SEL_RGMII;
263 regmap_update_bits(dwmac->intf_regmap, dwmac->intf_reg_off,
264 MX93_GPR_ENET_QOS_INTF_MODE_MASK, val);
265 usleep_range(50, 100);
266 val = MX93_GPR_ENET_QOS_INTF_SEL_RGMII | MX93_GPR_ENET_QOS_CLK_GEN_EN;
267 regmap_update_bits(dwmac->intf_regmap, dwmac->intf_reg_off,
268 MX93_GPR_ENET_QOS_INTF_MODE_MASK, val);
269
270 writel(old_ctrl, dwmac->base_addr + MAC_CTRL_REG);
271 }
272 }
273
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-07-25 23:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 19:49 [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Shenwei Wang
2023-07-25 21:04 ` Russell King (Oracle)
2023-07-26 15:00 ` [EXT] " Shenwei Wang
2023-07-26 15:09 ` Russell King (Oracle)
2023-07-26 16:10 ` Shenwei Wang
2023-07-26 16:29 ` Russell King (Oracle)
2023-07-26 17:03 ` Vladimir Oltean
2023-07-26 18:24 ` Shenwei Wang
2023-07-26 18:30 ` Andrew Lunn
2023-07-25 23:23 ` kernel test robot [this message]
2023-07-26 0:43 ` Vladimir Oltean
2023-07-26 15:10 ` [EXT] " Shenwei Wang
2023-07-26 15:29 ` Russell King (Oracle)
2023-07-26 15:59 ` Shenwei Wang
2023-07-26 17:01 ` Russell King (Oracle)
2023-07-26 18:47 ` Shenwei Wang
2023-07-26 19:02 ` Russell King (Oracle)
2023-07-26 19:17 ` Shenwei Wang
2023-07-27 8:58 ` Russell King (Oracle)
2023-07-27 13:03 ` Shenwei Wang
2023-07-26 8:32 ` Andrew Lunn
2023-07-26 11:58 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307260736.EE13gy3b-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=frank.li@nxp$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=joabreu@synopsys$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=shenwei.wang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox