From: Jakub Kicinski <kuba@kernel•org>
To: Alexander Duyck <alexander.duyck@gmail•com>
Cc: Yunsheng Lin <linyunsheng@huawei•com>,
Alexander Lobakin <aleksander.lobakin@intel•com>,
davem@davemloft•net, pabeni@redhat•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
Wei Fang <wei.fang@nxp•com>, Shenwei Wang <shenwei.wang@nxp•com>,
Clark Wang <xiaoning.wang@nxp•com>,
NXP Linux Team <linux-imx@nxp•com>,
Sunil Goutham <sgoutham@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
hariprasad <hkelam@marvell•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
Felix Fietkau <nbd@nbd•name>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Ryder Lee <ryder.lee@mediatek•com>,
Shayne Chen <shayne.chen@mediatek•com>,
Sean Wang <sean.wang@mediatek•com>, Kalle Valo <kvalo@kernel•org>,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
linux-rdma@vger•kernel.org, bpf@vger•kernel.org,
linux-wireless@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org
Subject: Re: [PATCH net-next v2] page_pool: split types and declarations from page_pool.h
Date: Wed, 26 Jul 2023 08:50:49 -0700 [thread overview]
Message-ID: <20230726085049.36b527a4@kernel.org> (raw)
In-Reply-To: <CAKgT0UfL4ri-o7WifeewpezGQY1UQKwcBEUSSY80DyKoE8g-0w@mail.gmail.com>
On Wed, 26 Jul 2023 08:39:43 -0700 Alexander Duyck wrote:
> > > I suppose the above suggestion is about splitting or naming by
> > > the user as the discussed in the below thread?
> > > https://lore.kernel.org/all/20230721182942.0ca57663@kernel.org/
> >
> > Actually my suggestion is more about defining boundaries for what is
> > meant to be used by drivers and what isn't. The stuff you could keep
> > in net/core/page_pool.h would only be usable by the files in net/core/
> > whereas the stuff you are keeping in the include/net/ folder is usable
> > by drivers. It is meant to prevent things like what you were
> > complaining about with the Mellanox drivers making use of interfaces
> > you didn't intend them to use.
FWIW moving stuff which is only supposed to be used by core (xdp, skb,
etc.) to net/core/page_pool.h is a good idea, too.
Seems a bit independent from splitting the main header, tho.
> > So for example you could pull out functions like
> > page_pool_return_skb_page, page_pool_use_xdp_mem,
> > page_pool_update_nid, and the like and look at relocating them into
> > the net/core/ folder and thereby prevent abuse of those functions by
> > drivers.
>
> Okay, maybe not page_pool_update_nid. It looks like that is already in
> use in the form of page_pool_nid_changed by drivers..
next prev parent reply other threads:[~2023-07-26 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:12 [PATCH net-next v2] page_pool: split types and declarations from page_pool.h Yunsheng Lin
2023-07-25 14:42 ` Ilias Apalodimas
2023-07-25 21:12 ` Jakub Kicinski
2023-07-26 6:41 ` Ilias Apalodimas
2023-07-26 10:48 ` Alexander Lobakin
2023-07-26 15:47 ` Jakub Kicinski
2023-07-27 11:47 ` Yunsheng Lin
2023-07-27 13:58 ` Alexander Lobakin
2023-07-25 15:47 ` Alexander H Duyck
2023-07-26 10:43 ` Alexander Lobakin
2023-07-26 11:23 ` Yunsheng Lin
2023-07-26 15:30 ` Alexander Duyck
2023-07-26 15:39 ` Alexander Duyck
2023-07-26 15:50 ` Jakub Kicinski [this message]
2023-07-26 16:42 ` Alexander Duyck
2023-07-26 15:41 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726085049.36b527a4@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kvalo@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linyunsheng@huawei$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=ryder.lee@mediatek$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shayne.chen@mediatek$(echo .)com \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
--cc=xiaoning.wang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox