From: "Michael S. Tsirkin" <mst@redhat•com>
To: Arseniy Krasnov <AVKrasnov@sberdevices•ru>
Cc: Stefan Hajnoczi <stefanha@redhat•com>,
Stefano Garzarella <sgarzare@redhat•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jason Wang <jasowang@redhat•com>,
Bobby Eshleman <bobby.eshleman@bytedance•com>,
kvm@vger•kernel.org, virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@sberdevices•ru, oxffffaa@gmail•com
Subject: Re: [PATCH net-next v4 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations
Date: Fri, 28 Jul 2023 01:45:10 -0400 [thread overview]
Message-ID: <20230728012845-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230727222627.1895355-1-AVKrasnov@sberdevices.ru>
On Fri, Jul 28, 2023 at 01:26:23AM +0300, Arseniy Krasnov wrote:
> Hello,
>
> this patchset is first of three parts of another big patchset for
> MSG_ZEROCOPY flag support:
> https://lore.kernel.org/netdev/20230701063947.3422088-1-AVKrasnov@sberdevices.ru/
overall looks good. Two points I'd like to see addressed:
- what's the performance with all these changes - still same?
- most systems have a copybreak scheme where buffers
smaller than a given size are copied directly.
This will address regression you see with small buffers -
but need to find that value. we know it's between 4k and 32k :)
> During review of this series, Stefano Garzarella <sgarzare@redhat•com>
> suggested to split it for three parts to simplify review and merging:
>
> 1) virtio and vhost updates (for fragged skbs) <--- this patchset
> 2) AF_VSOCK updates (allows to enable MSG_ZEROCOPY mode and read
> tx completions) and update for Documentation/.
> 3) Updates for tests and utils.
>
> This series enables handling of fragged skbs in virtio and vhost parts.
> Newly logic won't be triggered, because SO_ZEROCOPY options is still
> impossible to enable at this moment (next bunch of patches from big
> set above will enable it).
>
> I've included changelog to some patches anyway, because there were some
> comments during review of last big patchset from the link above.
>
> Head for this patchset is 9d0cd5d25f7d45bce01bbb3193b54ac24b3a60f3
>
> Link to v1:
> https://lore.kernel.org/netdev/20230717210051.856388-1-AVKrasnov@sberdevices.ru/
> Link to v2:
> https://lore.kernel.org/netdev/20230718180237.3248179-1-AVKrasnov@sberdevices.ru/
> Link to v3:
> https://lore.kernel.org/netdev/20230720214245.457298-1-AVKrasnov@sberdevices.ru/
>
> Changelog:
> * Patchset rebased and tested on new HEAD of net-next (see hash above).
> * See per-patch changelog after ---.
>
> Arseniy Krasnov (4):
> vsock/virtio/vhost: read data from non-linear skb
> vsock/virtio: support to send non-linear skb
> vsock/virtio: non-linear skb handling for tap
> vsock/virtio: MSG_ZEROCOPY flag support
>
> drivers/vhost/vsock.c | 14 +-
> include/linux/virtio_vsock.h | 6 +
> net/vmw_vsock/virtio_transport.c | 79 +++++-
> net/vmw_vsock/virtio_transport_common.c | 312 ++++++++++++++++++------
> 4 files changed, 330 insertions(+), 81 deletions(-)
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-07-28 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 22:26 [PATCH net-next v4 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations Arseniy Krasnov
2023-07-27 22:26 ` [PATCH net-next v4 1/4] vsock/virtio/vhost: read data from non-linear skb Arseniy Krasnov
2023-07-27 22:26 ` [PATCH net-next v4 2/4] vsock/virtio: support to send " Arseniy Krasnov
2023-07-27 22:26 ` [PATCH net-next v4 3/4] vsock/virtio: non-linear skb handling for tap Arseniy Krasnov
2023-07-27 22:26 ` [PATCH net-next v4 4/4] vsock/virtio: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-07-28 8:03 ` Arseniy Krasnov
2023-07-28 5:45 ` Michael S. Tsirkin [this message]
2023-07-28 8:00 ` [PATCH net-next v4 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations Arseniy Krasnov
2023-07-28 8:05 ` Arseniy Krasnov
2023-07-30 8:57 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728012845-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=AVKrasnov@sberdevices$(echo .)ru \
--cc=bobby.eshleman@bytedance$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=kernel@sberdevices$(echo .)ru \
--cc=kuba@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oxffffaa@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sgarzare@redhat$(echo .)com \
--cc=stefanha@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox