Subject: Re: [PATCH v2 20/28] net: wan: Add framer framework support

From: Herve Codina <[email-masked]>
Date: Tue, 1 Aug 2023 12:32:01 +0200

On Tue, 1 Aug 2023 11:56:12 +0200
Andrew Lunn <[email-masked]> wrote:

> > +int framer_pm_runtime_get(struct framer *framer)
> > +{
> > +	int ret;
> > +
> > +	if (!framer)
> > +		return 0;  
> 
> Can framer be a NULL pointer? This sort of test often covers up
> bugs. So either let it dereference the NULL pointer and opps, or
> return -EINVAL.
> 

Well, in the current usage, it cannot be a NULL pointer.
I will simply remove the check (every where it is present) and
dereference the pointer instead of returning -EINVAL.

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com