Subject: Re: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed

From: Jakub Kicinski <[email-masked]>
Date: Tue, 1 Aug 2023 12:58:28 -0700

On Tue, 1 Aug 2023 18:43:52 +0000 Shenwei Wang wrote:
> Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter  for fix_mac_speed

Looks like new platform enablement, the correct tree to target this 
at is net-next (i.e. [PATCH net-next]).

> > -----Original Message-----
> > From: Marc Kleine-Budde <[email-masked]>
> > Sent: Tuesday, August 1, 2023 1:37 AM
> > To: Shenwei Wang <[email-masked]>
> > Cc: Russell King <[email-masked]>; David S. Miller
> > <[email-masked]>; Eric Dumazet <[email-masked]>; Jakub
> > Kicinski <[email-masked]>; Paolo Abeni <[email-masked]>; Maxime
> > Coquelin <[email-masked]>; Shawn Guo <[email-masked]>;
> > Sascha Hauer <[email-masked]>; Neil Armstrong
> > <[email-masked]>; Kevin Hilman <[email-masked]>; Vinod
> > Koul <[email-masked]>; Chen-Yu Tsai <[email-masked]>; Jernej Skrabec
> > <[email-masked]>; Samuel Holland <[email-masked]>; Jose
> > Abreu <[email-masked]>; [email-masked]; Simon Horman
> > <[email-masked]>; Alexandre Torgue
> > <[email-masked]>; Giuseppe Cavallaro
> > <[email-masked]>; Nobuhiro Iwamatsu
> > <[email-masked]>; Fabio Estevam <[email-masked]>;
> > [email-masked]; Jerome Brunet
> > <[email-masked]>; Bartosz Golaszewski
> > <[email-masked]>; Wong Vee Khee <[email-masked]>; dl-
> > linux-imx <[email-masked]>; Andrew Halaney <[email-masked]>;
> > Bhupesh Sharma <[email-masked]>; Martin Blumenstingl
> > <[email-masked]>; Revanth Kumar Uppala
> > <[email-masked]>; Jochen Henneberg <[email-masked]>;
> > [email-masked]; [email-masked];
> > [email-masked]; [email-masked]; Pengutronix Kernel
> > Team <[email-masked]>
> > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
> > for fix_mac_speed

Why is this quote included? Please get a sane email client.

> > On 31.07.2023 11:19:28, Shenwei Wang wrote:  
> > > A mode parameter has been added to the callback function of
> > > fix_mac_speed to indicate the physical layer type.
> > >
> > > The mode can be one the following:
> > > 	MLO_AN_PHY	- Conventional PHY
> > > 	MLO_AN_FIXED	- Fixed-link mode
> > > 	MLO_AN_INBAND	- In-band protocol
> > >
> > > Also use short version of 'uint' to replace the 'unsigned int' in the
> > > function definitions.  
> > 
> > There are not many users of 'uint' in the kernel and it's not used in the stmmac
> > driver so far. From my point of view I would not introduce it and stick to the
> > standard 'unsigned int'.
> 
> Using 'uint' makes the code look cleaner because adding one extra
> parameter may cause some function declarations to span multiple
> lines.  This change keeps function declarations compact on a single
> line.

Marc is right. Just do it.