From: Jakub Kicinski <kuba@kernel•org>
To: YueHaibing <yuehaibing@huawei•com>
Cc: David Ahern <dsahern@kernel•org>,
Eric Dumazet <edumazet@google•com>, <davem@davemloft•net>,
<pabeni@redhat•com>, <yoshfuji@linux-ipv6•org>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<simon.horman@corigine•com>
Subject: Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report()
Date: Tue, 1 Aug 2023 19:10:58 -0700 [thread overview]
Message-ID: <20230801191058.0664b1b8@kernel.org> (raw)
In-Reply-To: <cad2b715-14fc-8424-f85d-b5391e0110dc@huawei.com>
On Wed, 2 Aug 2023 09:28:31 +0800 YueHaibing wrote:
> > that pattern shows up a few times:
>
> Ok, I will test and fix these if any.
Thanks, we may also want to add a
DEBUG_NET_WARN_ON_ONCE(len > INT_MAX)
in skb_push() but perhaps that's an overkill.
Most of those cases are probably legit (skb_.*_offset()
can well be negative if headers were already pulled).
next prev parent reply other threads:[~2023-08-02 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:43 [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report() Yue Haibing
2023-08-01 7:51 ` Eric Dumazet
2023-08-01 20:11 ` Jakub Kicinski
2023-08-02 0:52 ` David Ahern
2023-08-02 1:28 ` YueHaibing
2023-08-02 2:10 ` Jakub Kicinski [this message]
2023-08-02 3:18 ` David Ahern
2023-08-02 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801191058.0664b1b8@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox