Subject: Re: [PATCH net-next 5/7] ice: Add get C827 PHY index function

From: Jakub Kicinski <[email-masked]>
Date: Wed, 2 Aug 2023 19:28:27 -0700

On Tue,  1 Aug 2023 10:31:10 -0700 Tony Nguyen wrote:
> +bool ice_is_pf_c827(struct ice_hw *hw);
>  int ice_init_hw(struct ice_hw *hw);
>  void ice_deinit_hw(struct ice_hw *hw);
>  int ice_check_reset(struct ice_hw *hw);
> @@ -94,6 +95,10 @@ ice_aq_get_phy_caps(struct ice_port_info *pi, bool qual_mods, u8 report_mode,
>  		    struct ice_aqc_get_phy_caps_data *caps,
>  		    struct ice_sq_cd *cd);
>  int
> +ice_aq_get_netlist_node(struct ice_hw *hw, struct ice_aqc_get_link_topo *cmd,
> +			u8 *node_part_number, u16 *node_handle);

doesn't seem like this one needs to be declared in the header?

> +bool ice_is_pf_c827(struct ice_hw *hw);

and this one is declared twice