From: Maksim Kiselev <bigunclemax@gmail•com>
To: contact@jookia•org
Cc: aou@eecs•berkeley.edu, conor+dt@kernel•org, davem@davemloft•net,
devicetree@vger•kernel.org, edumazet@google•com,
jernej.skrabec@gmail•com, krzysztof.kozlowski+dt@linaro•org,
kuba@kernel•org, linux-arm-kernel@lists•infradead.org,
linux-can@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-riscv@lists•infradead.org, linux-sunxi@lists•linux.dev,
mkl@pengutronix•de, netdev@vger•kernel.org, pabeni@redhat•com,
palmer@dabbelt•com, paul.walmsley@sifive•com, robh+dt@kernel•org,
samuel@sholland•org, wens@csie•org, wg@grandegger•com
Subject: Re: [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes
Date: Sat, 5 Aug 2023 19:40:52 +0300 [thread overview]
Message-ID: <20230805164052.669184-1-bigunclemax@gmail.com> (raw)
In-Reply-To: <20230721221552.1973203-4-contact@jookia.org>
Hi John, Jernej
On Sat, Jul 22, 2023 at 08:15:51AM +1000, John Watts wrote:
> ...
> @@ -131,6 +131,18 @@ uart3_pb_pins: uart3-pb-pins {
> pins = "PB6", "PB7";
> function = "uart3";
> };
> +
> + /omit-if-no-ref/
> + can0_pins: can0-pins {
> + pins = "PB2", "PB3";
> + function = "can0";
> + };
> +
> + /omit-if-no-ref/
> + can1_pins: can1-pins {
> + pins = "PB4", "PB5";
> + function = "can1";
> + };
> ...
Should we also keep a pinctrl nodes itself in alphabetical order?
I mean placing a CAN nodes before `clk_pg11_pin` node?
Looks like the other nodes sorted in this way...
Cheers,
Maksim
next prev parent reply other threads:[~2023-08-05 16:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 22:15 [PATCH v2 0/4] Add support for Allwinner D1 CAN controllers John Watts
2023-07-21 22:15 ` [PATCH v2 1/4] dt-bindings: net: can: Add support for Allwinner D1 CAN controller John Watts
2023-07-22 9:29 ` Krzysztof Kozlowski
2023-07-21 22:15 ` [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes John Watts
2023-07-23 9:18 ` John Watts
2023-07-30 22:03 ` Jernej Škrabec
2023-07-31 2:38 ` John Watts
2023-08-05 16:40 ` Maksim Kiselev [this message]
2023-08-05 16:51 ` John Watts
2023-08-05 17:49 ` Jernej Škrabec
2023-08-06 6:33 ` John Watts
2023-08-06 11:42 ` Jernej Škrabec
2023-08-07 7:16 ` Marc Kleine-Budde
2023-08-07 7:30 ` Marc Kleine-Budde
2023-07-21 22:15 ` [PATCH v2 3/4] can: sun4i_can: Add acceptance register quirk John Watts
2023-07-21 22:15 ` [PATCH v2 4/4] can: sun4i_can: Add support for the Allwinner D1 John Watts
2023-08-22 12:30 ` Geert Uytterhoeven
2023-08-23 3:16 ` John Watts
2023-07-24 8:27 ` [PATCH v2 0/4] Add support for Allwinner D1 CAN controllers Marc Kleine-Budde
2023-09-01 16:25 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230805164052.669184-1-bigunclemax@gmail.com \
--to=bigunclemax@gmail$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=conor+dt@kernel$(echo .)org \
--cc=contact@jookia$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=samuel@sholland$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox