From: Geliang Tang <geliang.tang@suse•com>
To: Martin KaFai Lau <martin.lau@linux•dev>
Cc: Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Andrii Nakryiko <andrii@kernel•org>,
Martin KaFai Lau <martin.lau@linux•dev>,
Song Liu <song@kernel•org>, Yonghong Song <yhs@fb•com>,
John Fastabend <john.fastabend@gmail•com>,
KP Singh <kpsingh@kernel•org>,
Stanislav Fomichev <sdf@google•com>, Hao Luo <haoluo@google•com>,
Jiri Olsa <jolsa@kernel•org>,
Florent Revest <revest@chromium•org>,
Brendan Jackman <jackmanb@chromium•org>,
Matthieu Baerts <matthieu.baerts@tessares•net>,
Mat Martineau <martineau@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
John Johansen <john.johansen@canonical•com>,
Paul Moore <paul@paul-moore•com>,
James Morris <jmorris@namei•org>,
"Serge E. Hallyn" <serge@hallyn•com>,
Stephen Smalley <stephen.smalley.work@gmail•com>,
Eric Paris <eparis@parisplace•org>,
Mykola Lysenko <mykolal@fb•com>, Shuah Khan <shuah@kernel•org>,
Simon Horman <horms@kernel•org>,
bpf@vger•kernel.org, netdev@vger•kernel.org,
mptcp@lists•linux.dev, apparmor@lists•ubuntu.com,
linux-security-module@vger•kernel.org, selinux@vger•kernel.org,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp
Date: Mon, 7 Aug 2023 14:40:44 +0800 [thread overview]
Message-ID: <20230807064044.GA11180@localhost.localdomain> (raw)
In-Reply-To: <8b706f66-2afa-b3d0-a13a-11f1ffb452fe@linux.dev>
On Fri, Aug 04, 2023 at 05:23:32PM -0700, Martin KaFai Lau wrote:
> On 8/3/23 10:07 PM, Geliang Tang wrote:
> > Use rand() to generate a random netns name instead of using the fixed
> > name "mptcp_ns" for every test.
> >
> > By doing that, we can re-launch the test even if there was an issue
> > removing the previous netns or if by accident, a netns with this generic
> > name already existed on the system.
> >
> > Note that using a different name each will also help adding more
> > subtests in future commits.
Hi Martin,
I tried to run mptcp tests simultaneously, and got "Cannot create
namespace file "/var/run/netns/mptcp_ns": File exists" errors sometimes.
So I add this patch to fix it.
It's easy to reproduce, just run this commands in multiple terminals:
> for i in `seq 1 100`; do sudo ./test_progs -t mptcp; done
>
> I run test_progs repeatedly without rebooting qemu to save time. If there is
> a test did not clean up its netns, I would rather uncover it earlier and fix
> it instead. Randomizing the name is hiding the issue and does not help to
> uncover the broken test sooner. Although this change is to mptcp test alone,
> this could be referred in other future tests.
I added "ip netns show" after "ip netns del" in v12 to check if there is
a test did not clean up its netns.
Thanks,
-Geliang
>
> afaik, I don't remember bpf CI ever run into a test failure because the
> picked name had already been used by the system. It seems you ran into this
> issue a lot with the mptcp test in your setup. Could you explain a little
> more?
next prev parent reply other threads:[~2023-08-07 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 5:07 [PATCH bpf-next v11 0/5] bpf: Force to MPTCP Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 1/5] bpf: Add update_socket_protocol hook Geliang Tang
2023-08-05 0:00 ` Martin KaFai Lau
2023-08-04 5:07 ` [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp Geliang Tang
2023-08-05 0:23 ` Martin KaFai Lau
2023-08-07 6:40 ` Geliang Tang [this message]
2023-08-09 6:03 ` Martin KaFai Lau
2023-08-09 8:19 ` Geliang Tang
2023-08-11 5:53 ` Martin KaFai Lau
2023-08-11 9:29 ` Geliang Tang
2023-08-11 18:50 ` Martin KaFai Lau
2023-08-04 5:07 ` [PATCH bpf-next v11 3/5] selftests/bpf: Add two mptcp netns helpers Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 4/5] selftests/bpf: Drop unneeded checks for mptcp Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 5/5] selftests/bpf: Add mptcpify test Geliang Tang
2023-08-05 0:40 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807064044.GA11180@localhost.localdomain \
--to=geliang.tang@suse$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=apparmor@lists$(echo .)ubuntu.com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eparis@parisplace$(echo .)org \
--cc=haoluo@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jackmanb@chromium$(echo .)org \
--cc=jmorris@namei$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.johansen@canonical$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=martin.lau@linux$(echo .)dev \
--cc=martineau@kernel$(echo .)org \
--cc=matthieu.baerts@tessares$(echo .)net \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=mykolal@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paul@paul-moore$(echo .)com \
--cc=revest@chromium$(echo .)org \
--cc=sdf@google$(echo .)com \
--cc=selinux@vger$(echo .)kernel.org \
--cc=serge@hallyn$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=stephen.smalley.work@gmail$(echo .)com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox