Subject: Re: [PATCH v4] bnx2x: Fix error recovering in switch configuration

From: Jakub Kicinski <[email-masked]>
Date: Mon, 7 Aug 2023 14:35:39 -0700

On Mon, 7 Aug 2023 16:08:50 -0500 Thinh Tran wrote:
> >> +static inline void bnx2x_stop_nic(struct bnx2x *bp)  
> > 
> > can't it live in bnx2x_cmn.c ?  
> It's in common header file for also being used by bnx2x_vfpf.c.

And bnx2x_cmn.c is the common source file. I don't see why it has 
to be a static inline.

>>> Why make it a static inline?
>    
> Just make it inlined where it is called.