From: Herve Codina <herve.codina@bootlin•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Andrew Lunn <andrew@lunn•ch>, Rob Herring <robh+dt@kernel•org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
Conor Dooley <conor+dt@kernel•org>, Lee Jones <lee@kernel•org>,
Linus Walleij <linus.walleij@linaro•org>,
Qiang Zhao <qiang.zhao@nxp•com>, Li Yang <leoyang.li@nxp•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>, Jaroslav Kysela <perex@perex•cz>,
Takashi Iwai <tiwai@suse•com>,
Shengjiu Wang <shengjiu.wang@gmail•com>,
Xiubo Li <Xiubo.Lee@gmail•com>,
Fabio Estevam <festevam@gmail•com>,
Nicolin Chen <nicoleotsuka@gmail•com>,
Randy Dunlap <rdunlap@infradead•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-gpio@vger•kernel.org" <linux-gpio@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>
Subject: Re: [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec
Date: Tue, 8 Aug 2023 11:06:13 +0200 [thread overview]
Message-ID: <20230808110613.07e222a3@bootlin.com> (raw)
In-Reply-To: <a1b5120b-feb0-5c87-0605-e1e170d9268d@csgroup.eu>
On Tue, 8 Aug 2023 08:26:16 +0000
Christophe Leroy <christophe.leroy@csgroup•eu> wrote:
> Le 26/07/2023 à 17:02, Herve Codina a écrit :
> > The framer codec interracts with a framer.
> > It allows to use some of the framer timeslots as audio channels to
> > transport audio data over the framer E1/T1/J1 lines.
> > It also reports line carrier detection events through the ALSA jack
> > detection feature.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin•com>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup•eu>
>
> See below
>
> > +static int framer_dai_hw_rule_channels_by_format(struct snd_soc_dai *dai,
> > + struct snd_pcm_hw_params *params,
> > + unsigned int nb_ts)
> > +{
> > + struct snd_interval *c = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);
> > + snd_pcm_format_t format = params_format(params);
> > + struct snd_interval ch = {0};
> > +
> > + switch (snd_pcm_format_physical_width(format)) {
> > + case 8:
> > + ch.max = nb_ts;
> > + break;
> > + case 16:
> > + ch.max = nb_ts / 2;
> > + break;
> > + case 32:
> > + ch.max = nb_ts / 4;
> > + break;
> > + case 64:
> > + ch.max = nb_ts / 8;
> > + break;
> > + default:
> > + dev_err(dai->dev, "format physical width %u not supported\n",
> > + snd_pcm_format_physical_width(format));
> > + return -EINVAL;
> > + }
>
> What about
>
> width = snd_pcm_format_physical_width(format);
>
> if (width == 8 || width == 16 || width == 32 || width == 64) {
> ch.max = nb_ts * 8 / width;
> } else {
> dev_err(dai->dev, "format physical width %u not supported\n", width);
> return -EINVAL;
> }
>
Yes, indeed.
Will be changed in the next iteration.
Regards,
Hervé
next prev parent reply other threads:[~2023-08-08 16:08 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 15:01 [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer Herve Codina
2023-07-26 15:01 ` [PATCH v2 01/28] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-08-08 7:40 ` Christophe Leroy
2023-07-26 15:01 ` [PATCH v2 02/28] soc: fsl: cpm1: qmc: " Herve Codina
2023-08-08 7:40 ` Christophe Leroy
2023-07-26 15:01 ` [PATCH v2 03/28] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-08-08 7:41 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 04/28] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-08-08 7:41 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 05/28] dt-bindings: net: Add support for QMC HDLC Herve Codina
2023-07-27 8:19 ` Conor Dooley
2023-07-27 9:09 ` Herve Codina
2023-07-27 9:53 ` Conor Dooley
2023-07-27 10:34 ` Herve Codina
2023-07-26 15:02 ` [PATCH v2 06/28] net: wan: " Herve Codina
2023-08-01 9:31 ` Andrew Lunn
2023-08-01 10:07 ` Herve Codina
2023-08-08 8:02 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 07/28] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-07-26 15:02 ` [PATCH v2 08/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-08-01 9:33 ` Andrew Lunn
2023-08-01 10:05 ` Herve Codina
2023-08-08 8:04 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 09/28] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-08-08 8:04 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-08-01 9:36 ` Andrew Lunn
2023-08-01 10:23 ` Herve Codina
2023-08-08 8:05 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 11/28] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-08-08 8:05 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 12/28] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-08-08 8:06 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 13/28] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-08-08 8:06 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 14/28] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-08-08 8:08 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 15/28] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-08-08 8:09 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 16/28] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-08-08 8:09 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 17/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-08-08 8:10 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 18/28] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-08-08 8:10 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 19/28] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-08-08 8:11 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 20/28] net: wan: Add framer framework support Herve Codina
2023-08-01 9:56 ` Andrew Lunn
2023-08-01 10:32 ` Herve Codina
2023-08-08 8:11 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 21/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-08-01 10:05 ` Andrew Lunn
2023-08-01 10:35 ` Herve Codina
2023-08-03 0:40 ` Rob Herring
2023-08-03 8:11 ` Herve Codina
2023-07-26 15:02 ` [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting Herve Codina
2023-07-27 9:22 ` Lee Jones
2023-07-27 10:18 ` Herve Codina
2023-08-08 8:13 ` Christophe Leroy
2023-08-08 8:44 ` Herve Codina
2023-07-26 15:02 ` [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-08-01 10:22 ` Andrew Lunn
2023-08-01 10:44 ` Herve Codina
2023-08-01 10:52 ` Andrew Lunn
2023-08-01 11:12 ` Herve Codina
2023-08-08 8:15 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-08-07 13:05 ` Linus Walleij
2023-08-07 13:06 ` Linus Walleij
2023-08-07 13:17 ` Andrew Lunn
2023-08-07 14:36 ` Herve Codina
2023-08-07 13:09 ` Mark Brown
2023-08-08 9:00 ` Linus Walleij
2023-08-07 14:27 ` Herve Codina
2023-08-08 8:16 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 25/28] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-08-08 8:17 ` Christophe Leroy
2023-07-26 15:02 ` [PATCH v2 26/28] ASoC: codecs: Add support for the framer codec Herve Codina
2023-08-01 10:30 ` Andrew Lunn
2023-08-01 10:45 ` Herve Codina
2023-08-08 8:26 ` Christophe Leroy
2023-08-08 9:06 ` Herve Codina [this message]
2023-07-26 15:02 ` [PATCH v2 27/28] dt-bindings: net: fsl,qmc-hdlc: Add framer support Herve Codina
2023-07-27 8:12 ` Conor Dooley
2023-07-27 9:19 ` Herve Codina
2023-08-03 0:42 ` Rob Herring
2023-08-03 8:23 ` Herve Codina
2023-07-26 15:02 ` [PATCH v2 28/28] net: wan: fsl_qmc_hdlc: " Herve Codina
2023-08-08 8:29 ` Christophe Leroy
2023-08-01 10:34 ` [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808110613.07e222a3@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=qiang.zhao@nxp$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengjiu.wang@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox