Subject: Re: [PATCH net-next v2 04/10] tools/ynl: Add mcast-group schema parsing to ynl

From: Jakub Kicinski <[email-masked]>
Date: Wed, 16 Aug 2023 08:12:09 -0700

On Tue, 15 Aug 2023 20:42:48 +0100 Donald Hunter wrote:
> +class SpecMcastGroup(SpecElement):
> +    """Netlink Multicast Group
> +
> +    Information about a multicast group.

I'd add more info about value here. Say something along the lines
of value is specified in the spec only for classic netlink
(netlink-raw) families, genetlink families use dynamic ID allocation
so the ids of multicast groups need to be resolved at runtime.
value will be None for genetlink families.

> +
> +    Attributes:
> +        name      name of the mulitcast group
> +        value     numerical id of this multicast group for netlink-raw
> +        yaml      raw spec as loaded from the spec file
> +    """
> +    def __init__(self, family, yaml):
> +        super().__init__(family, yaml)
> +        self.value = self.yaml.get('value')