From: Jakub Kicinski <kuba@kernel•org>
To: "Michalik, Michal" <michal.michalik@intel•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"vadim.fedorenko@linux•dev" <vadim.fedorenko@linux•dev>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel•com>,
"jonathan.lemon@gmail•com" <jonathan.lemon@gmail•com>,
"pabeni@redhat•com" <pabeni@redhat•com>, poros <poros@redhat•com>,
"Olech, Milena" <milena.olech@intel•com>,
mschmidt <mschmidt@redhat•com>,
"linux-clk@vger•kernel.org" <linux-clk@vger•kernel.org>,
"bvanassche@acm•org" <bvanassche@acm•org>
Subject: Re: [PATCH RFC net-next v1 2/2] selftests/dpll: add DPLL system integration selftests
Date: Thu, 24 Aug 2023 08:49:34 -0700 [thread overview]
Message-ID: <20230824084934.3b9b96ee@kernel.org> (raw)
In-Reply-To: <CH3PR11MB84149ADA77B4A6FBD4F0C230E31DA@CH3PR11MB8414.namprd11.prod.outlook.com>
On Thu, 24 Aug 2023 08:59:53 +0000 Michalik, Michal wrote:
> >> The biggest concern for me is the requirement of selftests[2]:
> >> "Don't take too long;"
> >> This approach is reloading the modules few times to check few scenarios.
> >> Also, the DPLL subsystem is being tested against multiple requests - so
> >> it takes some time to finish (not too long but is definitely not instant).
> >
> > I think the time constraints are more of a question of practicality.
> > A developer should be able to run the tests as part of their workflow.
>
> That makes sense - agree. So Jakub, if I understand correctly we have a few
> different problems to solve here:
> 1) how to deploy the module:
> - now it's separated, we should consider e.g. netdevsim
> 2) if we should have those tests a part of selftests
> - I would remove it from selftests and move it to ./tools/testing
> 3) if we should use Python at all:
> - fast to develop and easy to maintain
> - might be problematic to deploy (no Python, VMs, embedded, no network etc.)
>
> Do I understand our current outcome of the discussion correctly?
Yes, and on (3) unless someone objects let's stick to Python.
next prev parent reply other threads:[~2023-08-24 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 15:22 [PATCH RFC net-next v1 0/2] selftests/dpll: DPLL subsystem integration tests Michal Michalik
2023-08-17 15:22 ` [PATCH RFC net-next v1 1/2] selftests/dpll: add DPLL module for integration selftests Michal Michalik
2023-08-17 15:22 ` [PATCH RFC net-next v1 2/2] selftests/dpll: add DPLL system " Michal Michalik
2023-08-18 21:08 ` Jakub Kicinski
2023-08-21 9:32 ` Michalik, Michal
2023-08-21 21:13 ` Jakub Kicinski
2023-08-24 8:59 ` Michalik, Michal
2023-08-24 15:49 ` Jakub Kicinski [this message]
2023-08-25 19:06 ` Michalik, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824084934.3b9b96ee@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=bvanassche@acm$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=michal.michalik@intel$(echo .)com \
--cc=milena.olech@intel$(echo .)com \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=poros@redhat$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox