Subject: Re: [net-next v2 5/5] net: wwan: t7xx: Devlink documentation

From: Simon Horman <[email-masked]>
Date: Thu, 24 Aug 2023 17:47:05 +0200

On Wed, Aug 23, 2023 at 10:21:29PM +0800, Jinjian Song wrote:
> From: Jinjian Song <[email-masked]>
> 
> Document the t7xx devlink commands usage for firmware flashing &
> coredump collection.
> 
> Base on the v5 patch version of follow series:
> 'net: wwan: t7xx: fw flashing & coredump support'
> (https://patchwork.kernel.org/project/netdevbpf/patch/f902d4[email-masked]/)
> 
> Signed-off-by: Jinjian Song <[email-masked]>

Hi Jinjian Song,

some minor feedback from my side.

...

> +
> +Coredump Collection
> +~~~~~~~~~~~~~~~~~~

nit: the line above seems to need one more '~'

> +
> +::
> +
> +  $ devlink region new mr_dump
> +
> +::
> +
> +  $ devlink region read mr_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del mr_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +The userspace application uses these commands for obtaining the modem component
> +logs when device encounters an exception.
> +
> +Second Stage Bootloader dump
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ditto.

> +
> +::
> +
> +  $ devlink region new lk_dump
> +
> +::
> +
> +  $ devlink region read lk_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del lk_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +In fastboot mode the userspace application uses these commands for obtaining the
> +current snapshot of second stage bootloader.
> +
> -- 
> 2.34.1
> 
>