Subject: Re: [PATCH iwl-next v3 2/8] ethtool: Add forced speed to supported link modes maps

From: Simon Horman <[email-masked]>
Date: Sun, 27 Aug 2023 18:59:17 +0200

On Wed, Aug 23, 2023 at 08:06:26PM +0200, Pawel Chmielewski wrote:
> From: Paul Greenwalt <[email-masked]>
> 
> The need to map Ethtool forced speeds to Ethtool supported link modes is
> common among drivers. To support this, add a common structure for forced
> speed maps and a function to init them.  This is solution was originally
> introduced in commit 1d4e4ecccb11 ("qede: populate supported link modes
> maps on module init") for qede driver.
> 
> ethtool_forced_speed_maps_init() should be called during driver init
> with an array of struct ethtool_forced_speed_map to populate the mapping.
> 
> Definitions for maps themselves are left in the driver code, as the sets
> of supported link modes may vary betwen the devices.

Hi Pawel,

a minor nit from my side is that checkpatch.pl --codespell
suggests betwen -> between

> 
> The qede driver was compile tested only.
> 
> Suggested-by: Andrew Lunn <[email-masked]>
> Signed-off-by: Paul Greenwalt <[email-masked]>

...