From: Simon Horman <horms@kernel•org>
To: Shinas Rasheed <srasheed@marvell•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
hgani@marvell•com, vimleshk@marvell•com, mschmidt@redhat•com,
egallen@redhat•com, Veerasenareddy Burru <vburru@marvell•com>,
Sathesh Edara <sedara@marvell•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Satananda Burla <sburla@marvell•com>,
Abhijit Ayarekar <aayarekar@marvell•com>
Subject: Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG
Date: Mon, 11 Sep 2023 20:01:13 +0200 [thread overview]
Message-ID: <20230911180113.GA113013@kernel.org> (raw)
In-Reply-To: <20230911092306.2132794-1-srasheed@marvell.com>
On Mon, Sep 11, 2023 at 02:23:06AM -0700, Shinas Rasheed wrote:
> Lengths of SG pointers are in big-endian
>
> Fixes: 37d79d059606 ("octeon_ep: add Tx/Rx processing and interrupt support")
> Signed-off-by: Shinas Rasheed <srasheed@marvell•com>
> ---
> drivers/net/ethernet/marvell/octeon_ep/octep_tx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_tx.c b/drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
> index 5a520d37bea0..7e99486c274b 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
> @@ -69,12 +69,12 @@ int octep_iq_process_completions(struct octep_iq *iq, u16 budget)
> compl_sg++;
>
> dma_unmap_single(iq->dev, tx_buffer->sglist[0].dma_ptr[0],
> - tx_buffer->sglist[0].len[0], DMA_TO_DEVICE);
> + tx_buffer->sglist[0].len[3], DMA_TO_DEVICE);
>
> i = 1; /* entry 0 is main skb, unmapped above */
> while (frags--) {
> dma_unmap_page(iq->dev, tx_buffer->sglist[i >> 2].dma_ptr[i & 3],
> - tx_buffer->sglist[i >> 2].len[i & 3], DMA_TO_DEVICE);
> + tx_buffer->sglist[i >> 2].len[3 - (i & 3)], DMA_TO_DEVICE);
> i++;
> }
Hi Shinas,
is this change also needed in octep_iq_process_completions() ?
The code there looks rather similar.
next prev parent reply other threads:[~2023-09-11 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 9:23 [net PATCH] octeon_ep: fix tx dma unmap len values in SG Shinas Rasheed
2023-09-11 18:01 ` Simon Horman [this message]
2023-09-12 7:04 ` Shinas Rasheed
2023-09-12 8:45 ` Paolo Abeni
2023-09-13 5:49 ` [EXT] " Shinas Rasheed
2023-09-13 8:41 ` [net PATCH v2] " Shinas Rasheed
2023-09-14 10:57 ` Simon Horman
2023-09-15 13:00 ` patchwork-bot+netdevbpf
[not found] ` <PH0PR18MB473404EA35ADAC222C9EB68FC7F1A@PH0PR18MB4734.namprd18.prod.outlook.com>
2023-09-12 19:45 ` [EXT] Re: [net PATCH] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911180113.GA113013@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=aayarekar@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=egallen@redhat$(echo .)com \
--cc=hgani@marvell$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=sedara@marvell$(echo .)com \
--cc=srasheed@marvell$(echo .)com \
--cc=vburru@marvell$(echo .)com \
--cc=vimleshk@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox