From: Simon Horman <horms@kernel•org>
To: Miquel Raynal <miquel.raynal@bootlin•com>
Cc: "Wolfgang Grandegger" <wg@grandegger•com>,
"Marc Kleine-Budde" <mkl@pengutronix•de>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Eric Dumazet" <edumazet@google•com>,
netdev@vger•kernel.org, linux-can@vger•kernel.org,
"Jérémie Dautheribes" <jeremie.dautheribes@bootlin•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
sylvain.girard@se•com, pascal.eberhard@se•com
Subject: Re: [PATCH net-next] can: sja1000: Fix comment
Date: Thu, 28 Sep 2023 14:35:56 +0200 [thread overview]
Message-ID: <20230928123556.GH24230@kernel.org> (raw)
In-Reply-To: <20230922155130.592187-1-miquel.raynal@bootlin.com>
On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote:
> There is likely a copy-paste error here, as the exact same comment
> appears below in this function, one time calling set_reset_mode(), the
> other set_normal_mode().
>
> Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")
I'm not sure this warrants a fixes tag, which implies backporting,
but in any case the tag is correct.
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin•com>
The above comment notwithstanding, this seems correct to me.
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2023-09-28 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:51 [PATCH net-next] can: sja1000: Fix comment Miquel Raynal
2023-09-28 12:35 ` Simon Horman [this message]
2023-10-01 17:13 ` Miquel Raynal
2023-10-04 10:14 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928123556.GH24230@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jeremie.dautheribes@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pascal.eberhard@se$(echo .)com \
--cc=sylvain.girard@se$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox