From: Simon Horman <horms@kernel•org>
To: Haiyang Zhang <haiyangz@microsoft•com>
Cc: linux-hyperv@vger•kernel.org, netdev@vger•kernel.org,
decui@microsoft•com, kys@microsoft•com, paulros@microsoft•com,
olaf@aepfle•de, vkuznets@redhat•com, davem@davemloft•net,
wei.liu@kernel•org, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, leon@kernel•org, longli@microsoft•com,
ssengar@linux•microsoft.com, linux-rdma@vger•kernel.org,
daniel@iogearbox•net, john.fastabend@gmail•com,
bpf@vger•kernel.org, ast@kernel•org, sharmaajay@microsoft•com,
hawk@kernel•org, tglx@linutronix•de,
shradhagupta@linux•microsoft.com, linux-kernel@vger•kernel.org,
stable@vger•kernel.org
Subject: Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling
Date: Fri, 29 Sep 2023 07:50:30 +0200 [thread overview]
Message-ID: <20230929055030.GS24230@kernel.org> (raw)
In-Reply-To: <20230929054757.GQ24230@kernel.org>
On Fri, Sep 29, 2023 at 07:47:57AM +0200, Simon Horman wrote:
> On Sat, Sep 23, 2023 at 06:31:45PM -0700, Haiyang Zhang wrote:
> > For an unknown TX CQE error type (probably from a newer hardware),
> > still free the SKB, update the queue tail, etc., otherwise the
> > accounting will be wrong.
> >
> > Also, TX errors can be triggered by injecting corrupted packets, so
> > replace the WARN_ONCE to ratelimited error logging, because we don't
> > need stack trace here.
> >
> > Cc: stable@vger•kernel.org
> > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft•com>
>
> Reviewed-by: Simon Horman <horms@kernel•org>
Sorry, one latent question.
The patch replaces WARN_ONCE with a net_ratelimit()'d netdev_err().
But I do wonder if, as a fix, netdev_err_once() would be more appropriate.
next prev parent reply other threads:[~2023-09-29 5:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 1:31 [PATCH net, 0/3] net: mana: Fix some TX processing bugs Haiyang Zhang
2023-09-24 1:31 ` [PATCH net, 1/3] net: mana: Fix TX CQE error handling Haiyang Zhang
2023-09-29 5:47 ` Simon Horman
2023-09-29 5:50 ` Simon Horman [this message]
2023-09-29 15:51 ` Haiyang Zhang
2023-09-30 18:16 ` Simon Horman
2023-09-24 1:31 ` [PATCH net, 2/3] net: mana: Fix the tso_bytes calculation Haiyang Zhang
2023-09-29 5:48 ` Simon Horman
2023-09-24 1:31 ` [PATCH net, 3/3] net: mana: Fix oversized sge0 for GSO packets Haiyang Zhang
2023-09-24 5:22 ` Greg KH
2023-09-24 20:20 ` Haiyang Zhang
2023-09-29 8:56 ` Simon Horman
2023-09-29 16:11 ` Haiyang Zhang
2023-09-30 18:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929055030.GS24230@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=sharmaajay@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=stable@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox