Subject: Re: [PATCH v7 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

From: Herve Codina <[email-masked]>
Date: Mon, 2 Oct 2023 13:54:58 +0200

Hi Rob, all,

On Fri, 29 Sep 2023 20:04:44 +0800
kernel test robot <[email-masked]> wrote:

> Hi Herve,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.6-rc3 next-20230929]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Herve-Codina/soc-fsl-cpm1-tsa-Fix-__iomem-addresses-declaration/20230928-151746
> base:   linus/master
> patch link:    https://lore.kernel.org/r/20230928070652.330429-26-herve.codina%40bootlin.com
> patch subject: [PATCH v7 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
> compiler: loongarch64-linux-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20230929/[email-masked]/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email-masked]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email-masked]/
> 
> dtcheck warnings: (new ones prefixed by >>)
> >> Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: 'oneOf' conditional failed, one must be fixed:  
>    	'type' is a required property
>    		hint: A vendor boolean property can use "type: boolean"
>    	Additional properties are not allowed ('default', 'enum' were unexpected)
>    		hint: A vendor boolean property can use "type: boolean"
>    	Additional properties are not allowed ('default' was unexpected)
>    		hint: A vendor string property with exact values has an implicit type
> >> 	Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: 'oneOf' conditional failed, one must be fixed:  
>    		'$ref' is a required property
>    		'allOf' is a required property
>    		hint: A vendor property needs a $ref to types.yaml
>    		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
>    	2048000 is not of type 'string'
>    		hint: A vendor string property with exact values has an implicit type
>    	4096000 is not of type 'string'
>    		hint: A vendor string property with exact values has an implicit type
>    	8192000 is not of type 'string'
>    		hint: A vendor string property with exact values has an implicit type
> 

This issue is related to '-bps' standard suffix not yet available in the
dt-schema release.
The commit adding '-pbs' suffix is
  commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second")
present in https://github.com/devicetree-org/dt-schema/

This point was previously discussed with Rob [1] and mentioned in the cover
letter of the series.

[1]: https://lore.kernel.org/linux-kernel/CAL_JsqJTruTExc=[email-masked]/

Best regards,
Hervé