Subject: Re: [PATCH net] ice: don't stop netdev tx queues when setting up XSK socket

From: Jakub Kicinski <[email-masked]>
Date: Tue, 3 Oct 2023 15:49:20 -0700

On Mon, 25 Sep 2023 10:19:57 -0700 Tony Nguyen wrote:
> Avoid stopping netdev tx queues during XSK setup by removing
> netif_tx_stop_queue() and netif_tx_start_queue().
> These changes prevent unnecessary stopping and starting of netdev
> transmit queues during the setup of XDP socket. Without this change,
> after stopping the XDP traffic flow tracker and then stopping
> the XDP prog - NETDEV WATCHDOG transmit queue timed out appears.

I think we need more info about what happens here.

Maybe ice_qp_ena() fails before it gets to the start?
If we don't understand what happens, exactly, we may be papering
over other bugs.
-- 
pw-bot: cr