Subject: Re: [PATCH] netem: Annotate struct disttable with __counted_by

From: Stephen Hemminger <[email-masked]>
Date: Tue, 3 Oct 2023 20:32:40 -0700

On Tue,  3 Oct 2023 16:18:23 -0700
Kees Cook <[email-masked]> wrote:

> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct disttable.
> 
> Cc: Stephen Hemminger <[email-masked]>
> Cc: Jamal Hadi Salim <[email-masked]>
> Cc: Cong Wang <[email-masked]>
> Cc: Jiri Pirko <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: Eric Dumazet <[email-masked]>
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Paolo Abeni <[email-masked]>
> Cc: [email-masked]
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <[email-masked]

Reviewed-by: Stephen Hemminger <[email-masked]>

PS: size is intended wrong in original code but that is not important.
Should have lined up with table[].