From: Kees Cook <keescook@chromium•org>
To: Simon Horman <horms@kernel•org>
Cc: Kees Cook <keescook@chromium•org>,
Simon Horman <simon.horman@corigine•com>,
Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
oss-drivers@corigine•com, netdev@vger•kernel.org,
Louis Peens <louis.peens@corigine•com>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Tom Rix <trix@redhat•com>,
linux-kernel@vger•kernel.org, linux-hardening@vger•kernel.org,
llvm@lists•linux.dev
Subject: [PATCH] nfp: Annotate struct nfp_reprs with __counted_by
Date: Tue, 3 Oct 2023 16:18:43 -0700 [thread overview]
Message-ID: <20231003231843.work.811-kees@kernel.org> (raw)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct nfp_reprs.
Cc: Simon Horman <simon.horman@corigine•com>
Cc: Jakub Kicinski <kuba@kernel•org>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: Eric Dumazet <edumazet@google•com>
Cc: Paolo Abeni <pabeni@redhat•com>
Cc: oss-drivers@corigine•com
Cc: netdev@vger•kernel.org
Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
Signed-off-by: Kees Cook <keescook@chromium•org>
---
drivers/net/ethernet/netronome/nfp/nfp_net_repr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
index 48a74accbbd3..77bf4198dbde 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
@@ -18,7 +18,7 @@ struct nfp_port;
*/
struct nfp_reprs {
unsigned int num_reprs;
- struct net_device __rcu *reprs[];
+ struct net_device __rcu *reprs[] __counted_by(num_reprs);
};
/**
--
2.34.1
next reply other threads:[~2023-10-03 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 23:18 Kees Cook [this message]
2023-10-03 23:39 ` [PATCH] nfp: Annotate struct nfp_reprs with __counted_by Gustavo A. R. Silva
2023-10-04 5:13 ` Louis Peens
2023-10-06 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003231843.work.811-kees@kernel.org \
--to=keescook@chromium$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=louis.peens@corigine$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=trix@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox