From: kernel test robot <lkp@intel•com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Jakub Kicinski <kuba@kernel•org>
Cc: oe-kbuild-all@lists•linux.dev, netdev@vger•kernel.org,
bpf@vger•kernel.org, "Björn Töpel" <bjorn@kernel•org>,
"Alexei Starovoitov" <ast@kernel•org>,
"Andrii Nakryiko" <andrii@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Eric Dumazet" <edumazet@google•com>,
"Hao Luo" <haoluo@google•com>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"Jiri Olsa" <jolsa@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Jonathan Lemon" <jonathan.lemon@gmail•com>,
"KP Singh" <kpsingh@kernel•org>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel•com>,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
"Martin KaFai Lau" <martin.lau@linux•dev>,
"Paolo Abeni" <pabeni@redhat•com>, "Song Liu" <song@kernel•org>,
"Stanislav Fomichev" <sdf@google•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Yonghong Song" <yonghong.song@linux•dev>
Subject: Re: [PATCH bpf-next v2] net: Add a warning if NAPI cb missed xdp_do_flush().
Date: Sat, 7 Oct 2023 01:21:41 +0800 [thread overview]
Message-ID: <202310070134.JX5try68-lkp@intel.com> (raw)
In-Reply-To: <20231006154933.mQgxQHHt@linutronix.de>
Hi Sebastian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/net-Add-a-warning-if-NAPI-cb-missed-xdp_do_flush/20231006-235117
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20231006154933.mQgxQHHt%40linutronix.de
patch subject: [PATCH bpf-next v2] net: Add a warning if NAPI cb missed xdp_do_flush().
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231007/202310070134.JX5try68-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231007/202310070134.JX5try68-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel•com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310070134.JX5try68-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/core/filter.c:4211:6: warning: no previous prototype for 'xdp_do_check_flushed' [-Wmissing-prototypes]
4211 | void xdp_do_check_flushed(struct napi_struct *napi)
| ^~~~~~~~~~~~~~~~~~~~
vim +/xdp_do_check_flushed +4211 net/core/filter.c
4209
4210 #if defined(CONFIG_DEBUG_NET) && defined(CONFIG_BPF_SYSCALL)
> 4211 void xdp_do_check_flushed(struct napi_struct *napi)
4212 {
4213 bool ret;
4214
4215 ret = dev_check_flush();
4216 ret |= cpu_map_check_flush();
4217 ret |= xsk_map_check_flush();
4218
4219 WARN_ONCE(ret, "Missing xdp_do_flush() invocation after NAPI by %ps\n",
4220 napi->poll);
4221 }
4222 #endif
4223
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-06 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:58 [PATCH bpf-next] net: Add a warning if NAPI cb missed xdp_do_flush() Sebastian Andrzej Siewior
2023-09-29 17:52 ` Toke Høiland-Jørgensen
2023-10-04 14:09 ` Jakub Kicinski
2023-10-06 15:49 ` [PATCH bpf-next v2] " Sebastian Andrzej Siewior
2023-10-06 17:21 ` kernel test robot [this message]
2023-10-06 19:31 ` Jakub Kicinski
2023-10-07 15:43 ` [PATCH bpf-next v3] " Sebastian Andrzej Siewior
2023-10-10 6:57 ` [PATCH bpf-next -v4] " Sebastian Andrzej Siewior
2023-10-11 4:42 ` John Fastabend
2023-10-16 11:56 ` Daniel Borkmann
2023-10-16 12:57 ` [PATCH bpf-next -v5] " Sebastian Andrzej Siewior
2023-10-17 13:10 ` patchwork-bot+netdevbpf
2023-10-08 13:48 ` [PATCH bpf-next v2] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310070134.JX5try68-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=song@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox