From: Jakub Kicinski <kuba@kernel•org>
To: Xabier Marquiegui <reibax@gmail•com>
Cc: chrony-dev@chrony•tuxfamily.org, davem@davemloft•net,
horms@kernel•org, jstultz@google•com, mlichvar@redhat•com,
netdev@vger•kernel.org, ntp-lists@mattcorallo•com,
richardcochran@gmail•com, rrameshbabu@nvidia•com,
shuah@kernel•org, tglx@linutronix•de, vinicius.gomes@intel•com
Subject: Re: [PATCH net-next v5 5/6] ptp: add debugfs interface to see applied channel masks
Date: Thu, 12 Oct 2023 16:37:33 -0700 [thread overview]
Message-ID: <20231012163733.1f61a56d@kernel.org> (raw)
In-Reply-To: <20231011223604.4570-1-reibax@gmail.com>
On Thu, 12 Oct 2023 00:36:04 +0200 Xabier Marquiegui wrote:
> Jakub Kicinski said:
> > If it's a self-test it should probably be included in the Makefile
> > so that bots run it.
>
> Thank you for your input Jakub. It's actually designed as a debug tool for
> humans. I wasn't thinking about self-tests, and I can't really think of how
> that could be pulled of in this specific case. I hope that's ok. If not we
> can try to throw a few ideas around and see if we find a way.
Let's not throw random non-test scripts into selftests. It adds
confusion to our pitiful kernel testing story :(
The netdevsim driver which is supposed to be used for uAPI selftests
now supports PHCs. Maybe we can extend it and build a proper-er test?
Whether we'd then want to move the debugfs entries onto netdevsim
or leave them where you have then now is another question..
next prev parent reply other threads:[~2023-10-12 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 22:49 [PATCH net-next v5 0/6] ptp: Support for multiple filtered timestamp event queue readers Xabier Marquiegui
2023-10-08 22:49 ` [PATCH net-next v5 1/6] posix-clock: introduce posix_clock_context concept Xabier Marquiegui
2023-10-09 2:04 ` Richard Cochran
2023-10-11 22:30 ` Xabier Marquiegui
2023-10-09 14:52 ` Thomas Gleixner
2023-10-08 22:49 ` [PATCH net-next v5 2/6] ptp: Replace timestamp event queue with linked list Xabier Marquiegui
2023-10-08 22:49 ` [PATCH net-next v5 3/6] ptp: support multiple timestamp event readers Xabier Marquiegui
2023-10-08 22:49 ` [PATCH net-next v5 4/6] ptp: support event queue reader channel masks Xabier Marquiegui
2023-10-08 22:49 ` [PATCH net-next v5 5/6] ptp: add debugfs interface to see applied " Xabier Marquiegui
2023-10-10 0:54 ` Jakub Kicinski
2023-10-11 22:36 ` Xabier Marquiegui
2023-10-12 23:37 ` Jakub Kicinski [this message]
2023-10-16 8:14 ` Xabier Marquiegui
2023-10-08 22:49 ` [PATCH net-next v5 6/6] ptp: add testptp mask test Xabier Marquiegui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012163733.1f61a56d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=chrony-dev@chrony$(echo .)tuxfamily.org \
--cc=davem@davemloft$(echo .)net \
--cc=horms@kernel$(echo .)org \
--cc=jstultz@google$(echo .)com \
--cc=mlichvar@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ntp-lists@mattcorallo$(echo .)com \
--cc=reibax@gmail$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=vinicius.gomes@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox