Subject: Re: [PATCH] net: phy: smsc: replace deprecated strncpy with ethtool_sprintf

From: Simon Horman <[email-masked]>
Date: Sun, 15 Oct 2023 17:00:03 +0200

On Thu, Oct 12, 2023 at 10:27:52PM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> ethtool_sprintf() is designed specifically for get_strings() usage.
> Let's replace strncpy in favor of this dedicated helper function.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: [email-masked]
> Signed-off-by: Justin Stitt <[email-masked]>
> ---
> Note: build-tested only.
> 
> Found with: $ rg "strncpy\("

I agree that this is functionally equivalent.

Reviewed-by: Simon Horman <[email-masked]>