Subject: Re: [PATCH bpf-next v4 03/11] tools: ynl: Print xsk-features from the sample

From: Jakub Kicinski <[email-masked]>
Date: Fri, 20 Oct 2023 18:06:31 -0700

On Thu, 19 Oct 2023 10:49:36 -0700 Stanislav Fomichev wrote:
> Regenerate the userspace specs and print xsk-features bitmask.

I'm afraid you regenerated in previous patch already :]
Perhaps we should add an easy-to-use flag to ynl-regen to skip tools/ ?

> diff --git a/tools/net/ynl/samples/netdev.c b/tools/net/ynl/samples/netdev.c
> index b828225daad0..da7c2848f773 100644
> --- a/tools/net/ynl/samples/netdev.c
> +++ b/tools/net/ynl/samples/netdev.c
> @@ -44,6 +44,12 @@ static void netdev_print_device(struct netdev_dev_get_rsp *d, unsigned int op)
>  			printf(" %s", netdev_xdp_rx_metadata_str(1 << i));
>  	}
>  
> +	printf(" xsk-features (%llx):", d->xsk_features);
> +	for (int i = 0; d->xsk_features > 1U << i; i++) {

Shouldn't this be >= ?

> +		if (d->xsk_features & (1U << i))
> +			printf(" %s", netdev_xsk_flags_str(1 << i));
> +	}