Subject: Re: [net-next PATCH v6 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue

From: Jakub Kicinski <[email-masked]>
Date: Tue, 24 Oct 2023 15:45:48 -0700

Let's beef up the docs here.

On Mon, 23 Oct 2023 18:33:24 -0700 Amritha Nambiar wrote:
> +  -
> +    name: queue
> +    attributes:
> +      -
> +        name: queue-id
> +        doc: queue index

Queue index, most queue types are indexed like a C array,
with indexes starting at 0 and ending at queue count - 1.
Queue indexes are scoped to an interface and queue type.

> +        type: u32
> +      -
> +        name: ifindex
> +        doc: netdev ifindex

ifindex of the netdevice to which the queue belongs.

> +        type: u32
> +        checks:
> +          min: 1
> +      -
> +        name: queue-type
> +        doc: queue type as rx, tx
> +        type: u32
> +        enum: queue-type
> +      -
> +        name: napi-id
> +        doc: napi id

ID of the NAPI instance which services this queue.

> +        type: u32
> +
>  operations:
>    list:
>      -
> @@ -120,6 +147,27 @@ operations:
>        doc: Notification about device configuration being changed.
>        notify: dev-get
>        mcgrp: mgmt
> +    -
> +      name: queue-get
> +      doc: queue information

Get queue information from the kernel. Only configured queues will 
be reported (as opposed to all available queues).

> +      attribute-set: queue