Subject: Re: [PATCH net] s390/ism: ism driver implies smc protocol

From: Simon Horman <[email-masked]>
Date: Wed, 15 Nov 2023 10:23:04 +0000

On Tue, Nov 14, 2023 at 10:17:18AM +0100, Gerd Bayer wrote:
> Since commit a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
> you can build the ism code without selecting the SMC network protocol.
> That leaves some ism functions be reported as unused. Move these
> functions under the conditional compile with CONFIG_SMC.
> 
> Also codify the suggestion to also configure the SMC protocol in ism's
> Kconfig - but with an "imply" rather than a "select" as SMC depends on
> other config options and allow for a deliberate decision not to build
> SMC. Also, mention that in ISM's help.
> 
> Fixes: a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
> Reported-by: Randy Dunlap <[email-masked]>
> Closes: https://lore.kernel.org/netdev/[email-masked]/
> Signed-off-by: Gerd Bayer <[email-masked]>
> Reviewed-by: Wenjia Zhang <[email-masked]>

Hi Gerd,

In a similar vein, I am wondering if the forward declaration of ism_ops
could be removed.  In my very light compile test it shows up as unused when
CONFIG_SMC is unset.