From: Simon Horman <horms@kernel•org>
To: Raju Rangoju <Raju.Rangoju@amd•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, Shyam-sundar.S-k@amd•com,
Sudheesh Mavila <sudheesh.mavila@amd•com>
Subject: Re: [PATCH v2 net-next 2/4] amd-xgbe: add support for Crater ethernet device
Date: Sun, 19 Nov 2023 16:42:54 +0000 [thread overview]
Message-ID: <20231119164254.GD186930@vergenet.net> (raw)
In-Reply-To: <20231116135416.3371367-3-Raju.Rangoju@amd.com>
On Thu, Nov 16, 2023 at 07:24:14PM +0530, Raju Rangoju wrote:
> Add the necessary support to enable Crater ethernet device. Since the
> BAR1 address cannot be used to access the XPCS registers on Crater, use
> the pci_{read/write}_config_dword calls.
>
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd•com>
...
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
...
> @@ -479,6 +492,22 @@ static int __maybe_unused xgbe_pci_resume(struct device *dev)
> return ret;
> }
>
> +static struct xgbe_version_data xgbe_v3 = {
> + .init_function_ptrs_phy_impl = xgbe_init_function_ptrs_phy_v2,
> + .xpcs_access = XGBE_XPCS_ACCESS_V3,
> + .mmc_64bit = 1,
> + .tx_max_fifo_size = 65536,
> + .rx_max_fifo_size = 65536,
> + .tx_tstamp_workaround = 1,
> + .ecc_support = 1,
> + .i2c_support = 1,
> + .irq_reissue_support = 1,
> + .tx_desc_prefetch = 5,
> + .rx_desc_prefetch = 5,
> + .an_cdr_workaround = 0,
> + .enable_rrc = 0,
> +};
Hi Raju and Sudheesh,
W=1 allmodconfig builds on x86_64 with gcc-13 and clang-16 flag that
xgbe_v3 us defined but not used.
Please take care to arrange patch-sets so that each patch builds
without introducing new warnings.
> +
> static struct xgbe_version_data xgbe_v2a = {
> .init_function_ptrs_phy_impl = xgbe_init_function_ptrs_phy_v2,
> .xpcs_access = XGBE_XPCS_ACCESS_V2,
...
next prev parent reply other threads:[~2023-11-19 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 13:54 [PATCH v2 net-next 0/4] amd-xgbe: add support for AMD Crater Raju Rangoju
2023-11-16 13:54 ` [PATCH v2 net-next 1/4] amd-xgbe: reorganize the code of XPCS access Raju Rangoju
2023-11-19 16:37 ` Simon Horman
2023-11-16 13:54 ` [PATCH v2 net-next 2/4] amd-xgbe: add support for Crater ethernet device Raju Rangoju
2023-11-19 16:42 ` Simon Horman [this message]
2023-11-16 13:54 ` [PATCH v2 net-next 3/4] amd-xgbe: add support for new pci device id 0x1641 Raju Rangoju
2023-11-16 13:54 ` [PATCH v2 net-next 4/4] amd-xgbe: use smn functions to avoid race Raju Rangoju
2023-11-16 20:49 ` kernel test robot
2023-11-22 16:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231119164254.GD186930@vergenet.net \
--to=horms@kernel$(echo .)org \
--cc=Raju.Rangoju@amd$(echo .)com \
--cc=Shyam-sundar.S-k@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sudheesh.mavila@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox