From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
almasrymina@google•com, hawk@kernel•org,
ilias.apalodimas@linaro•org, dsahern@gmail•com,
dtatulea@nvidia•com, willemb@google•com,
Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next v3 04/13] net: page_pool: stash the NAPI ID for easier access
Date: Tue, 21 Nov 2023 19:44:11 -0800 [thread overview]
Message-ID: <20231122034420.1158898-5-kuba@kernel.org> (raw)
In-Reply-To: <20231122034420.1158898-1-kuba@kernel.org>
To avoid any issues with race conditions on accessing napi
and having to think about the lifetime of NAPI objects
in netlink GET - stash the napi_id to which page pool
was linked at creation time.
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
include/net/page_pool/types.h | 1 +
net/core/page_pool_user.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
index b258a571201e..7e47d7bb2c1e 100644
--- a/include/net/page_pool/types.h
+++ b/include/net/page_pool/types.h
@@ -193,6 +193,7 @@ struct page_pool {
/* User-facing fields, protected by page_pools_lock */
struct {
struct hlist_node list;
+ u32 napi_id;
u32 id;
} user;
};
diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
index 1591dbd66d51..23074d4c75fc 100644
--- a/net/core/page_pool_user.c
+++ b/net/core/page_pool_user.c
@@ -37,9 +37,11 @@ int page_pool_list(struct page_pool *pool)
if (err < 0)
goto err_unlock;
- if (pool->slow.netdev)
+ if (pool->slow.netdev) {
hlist_add_head(&pool->user.list,
&pool->slow.netdev->page_pools);
+ pool->user.napi_id = pool->p.napi ? pool->p.napi->napi_id : 0;
+ }
mutex_unlock(&page_pools_lock);
return 0;
--
2.42.0
next prev parent reply other threads:[~2023-11-22 3:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 3:44 [PATCH net-next v3 00/13] net: page_pool: add netlink-based introspection Jakub Kicinski
2023-11-22 3:44 ` [PATCH net-next v3 01/13] net: page_pool: factor out uninit Jakub Kicinski
2023-11-22 8:38 ` Eric Dumazet
2023-11-22 14:15 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 02/13] net: page_pool: id the page pools Jakub Kicinski
2023-11-22 8:40 ` Eric Dumazet
2023-11-22 14:16 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 03/13] net: page_pool: record pools per netdev Jakub Kicinski
2023-11-22 8:55 ` Eric Dumazet
2023-11-22 15:44 ` Jakub Kicinski
2023-11-22 14:20 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` Jakub Kicinski [this message]
2023-11-22 8:57 ` [PATCH net-next v3 04/13] net: page_pool: stash the NAPI ID for easier access Eric Dumazet
2023-11-22 14:21 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 05/13] eth: link netdev to page_pools in drivers Jakub Kicinski
2023-11-22 8:59 ` Eric Dumazet
2023-11-22 14:22 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 06/13] net: page_pool: add nlspec for basic access to page pools Jakub Kicinski
2023-11-22 9:00 ` Eric Dumazet
2023-11-22 14:24 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 07/13] net: page_pool: implement GET in the netlink API Jakub Kicinski
2023-11-22 9:35 ` Eric Dumazet
2023-11-22 14:39 ` Jesper Dangaard Brouer
2023-11-22 16:00 ` Jakub Kicinski
2023-11-22 16:21 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 08/13] net: page_pool: add netlink notifications for state changes Jakub Kicinski
2023-11-22 9:44 ` Eric Dumazet
2023-11-22 14:41 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 09/13] net: page_pool: report amount of memory held by page pools Jakub Kicinski
2023-11-22 10:16 ` Eric Dumazet
2023-11-22 16:03 ` Jakub Kicinski
2023-11-22 16:20 ` Eric Dumazet
2023-11-22 15:24 ` Jesper Dangaard Brouer
2023-11-22 16:06 ` Jakub Kicinski
2023-11-22 16:09 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 10/13] net: page_pool: report when page pool was destroyed Jakub Kicinski
2023-11-22 9:02 ` Jesper Dangaard Brouer
2023-11-22 10:21 ` Eric Dumazet
2023-11-22 3:44 ` [PATCH net-next v3 11/13] net: page_pool: expose page pool stats via netlink Jakub Kicinski
2023-11-22 10:27 ` Eric Dumazet
2023-11-22 15:51 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 12/13] net: page_pool: mute the periodic warning for visible page pools Jakub Kicinski
2023-11-22 13:53 ` Eric Dumazet
2023-11-22 16:06 ` Jesper Dangaard Brouer
2023-11-22 3:44 ` [PATCH net-next v3 13/13] tools: ynl: add sample for getting page-pool information Jakub Kicinski
2023-11-22 16:17 ` Jesper Dangaard Brouer
2023-11-25 20:57 ` [PATCH net-next v3 00/13] net: page_pool: add netlink-based introspection Shakeel Butt
2023-11-26 22:43 ` Jakub Kicinski
2023-11-27 6:54 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122034420.1158898-5-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=almasrymina@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=dtatulea@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox