From: Simon Horman <horms@kernel•org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech•se>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Richard Cochran <richardcochran@gmail•com>,
netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering•com>
Subject: Re: [net-next v3 1/5] net: ethernet: renesas: rcar_gen4_ptp: Remove incorrect comment
Date: Wed, 22 Nov 2023 20:32:22 +0000 [thread overview]
Message-ID: <20231122203222.GD6731@kernel.org> (raw)
In-Reply-To: <20231121155306.515446-2-niklas.soderlund+renesas@ragnatech.se>
On Tue, Nov 21, 2023 at 04:53:02PM +0100, Niklas Söderlund wrote:
> The comments intent was to indicates which function uses the enum. While
> upstreaming rcar_gen4_ptp the function was renamed but this comment was
> left with the old function name.
>
> Instead of correcting the comment remove it, it adds little value.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech•se>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2023-11-22 20:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:53 [net-next v3 0/5] net: ethernet: renesas: rcar_gen4_ptp: Add V4H support Niklas Söderlund
2023-11-21 15:53 ` [net-next v3 1/5] net: ethernet: renesas: rcar_gen4_ptp: Remove incorrect comment Niklas Söderlund
2023-11-22 20:32 ` Simon Horman [this message]
2023-11-21 15:53 ` [net-next v3 2/5] net: ethernet: renesas: rcar_gen4_ptp: Fail on unknown register layout Niklas Söderlund
2023-11-22 20:32 ` Simon Horman
2023-11-21 15:53 ` [net-next v3 3/5] net: ethernet: renesas: rcar_gen4_ptp: Prepare for shared " Niklas Söderlund
2023-11-22 20:32 ` Simon Horman
2023-11-21 15:53 ` [net-next v3 4/5] net: ethernet: renesas: rcar_gen4_ptp: Get clock increment from clock rate Niklas Söderlund
2023-11-22 20:33 ` Simon Horman
2023-11-21 15:53 ` [net-next v3 5/5] net: ethernet: renesas: rcar_gen4_ptp: Break out to module Niklas Söderlund
2023-11-22 20:33 ` Simon Horman
2023-11-23 11:10 ` [net-next v3 0/5] net: ethernet: renesas: rcar_gen4_ptp: Add V4H support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122203222.GD6731@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.soderlund+renesas@ragnatech$(echo .)se \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=wsa+renesas@sang-engineering$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox