Subject: Re: [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars

From: Simon Horman <[email-masked]>
Date: Fri, 1 Dec 2023 09:58:48 +0000

On Wed, Nov 29, 2023 at 02:36:11AM -0500, Jan Glaza wrote:
> Add const modifier to function parameters and variables where appropriate
> in ice_base.c and corresponding declarations in ice_base.h.
> 
> The reason for starting the change is that read-only pointers should be
> marked as const when possible to allow for smoother and more optimal code
> generation and optimization as well as allowing the compiler to warn the
> developer about potentially unwanted modifications, while not carrying
> noticable negative impact.

Hi Jan,

it's probably not worth respinning for this, but: noticeable

> 
> Reviewed-by: Andrii Staikov <[email-masked]>
> Reviewed-by: Sachin Bahadur <[email-masked]>
> Signed-off-by: Jan Glaza <[email-masked]>
> ---
> This change is done in one file to get comment feedback and, if positive,
> will be rolled out across the entire ice driver code.

The nit above notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>