Subject: Re: [PATCH net-next v1 4/6] tools/net/ynl: Add binary and pad support to structs for tc

From: Jakub Kicinski <[email-masked]>
Date: Fri, 1 Dec 2023 18:06:46 -0800

On Thu, 30 Nov 2023 21:49:56 +0000 Donald Hunter wrote:
> The tc netlink-raw family needs binary and pad types for several
> qopt C structs. Add support for them to ynl.

Nice reuse of the concept of "pad", I don't see why not:

Reviewed-by: Jakub Kicinski <[email-masked]>

> +                value = msg.raw[offset:offset+m.len]

What does Python style guide say about spaces around '+' here?
I tend to use C style, no idea if it's right.