Subject: Re: [PATCH net-next 2/4] net/sched: add helper to check if a notification is needed

From: Jakub Kicinski <[email-masked]>
Date: Sat, 2 Dec 2023 11:18:12 -0800

On Fri,  1 Dec 2023 17:43:12 -0300 Pedro Tammela wrote:
> +static inline bool tc_should_notify(const struct net *net, u16 nlflags)

nit: tc_notify_needed() ? doesn't matter

> +{
> +	return (nlflags & NLM_F_ECHO) || rtnl_has_listeners(net, RTNLGRP_TC);

I think it'd be nice to have an rtnl_* helper which looks at the flags
as well. With a proper kdoc. Maybe someone will notice that and remember
to implement F_ECHO for their command?