From: Shakeel Butt <shakeelb@google•com>
To: Coco Li <lixiaoyan@google•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Neal Cardwell <ncardwell@google•com>,
Mubashir Adnan Qureshi <mubashirq@google•com>,
Paolo Abeni <pabeni@redhat•com>, Andrew Lunn <andrew@lunn•ch>,
Jonathan Corbet <corbet@lwn•net>,
David Ahern <dsahern@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
netdev@vger•kernel.org, Chao Wu <wwchao@google•com>,
Wei Wang <weiwan@google•com>,
Pradeep Nemavat <pnemavat@google•com>
Subject: Re: [PATCH v8 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption
Date: Sat, 2 Dec 2023 20:34:33 +0000 [thread overview]
Message-ID: <20231202203433.ifi6dn74hgnseq4y@google.com> (raw)
In-Reply-To: <20231129072756.3684495-1-lixiaoyan@google.com>
On Wed, Nov 29, 2023 at 07:27:51AM +0000, Coco Li wrote:
> Currently, variable-heavy structs in the networking stack is organized
> chronologically, logically and sometimes by cacheline access.
>
> This patch series attempts to reorganize the core networking stack
> variables to minimize cacheline consumption during the phase of data
> transfer. Specifically, we looked at the TCP/IP stack and the fast
> path definition in TCP.
>
> For documentation purposes, we also added new files for each core data
> structure we considered, although not all ended up being modified due
> to the amount of existing cacheline they span in the fast path. In
> the documentation, we recorded all variables we identified on the
> fast path and the reasons. We also hope that in the future when
> variables are added/modified, the document can be referred to and
> updated accordingly to reflect the latest variable organization.
>
> Tested:
> Our tests were run with neper tcp_rr using tcp traffic. The tests have $cpu
> number of threads and variable number of flows (see below).
>
> Tests were run on 6.5-rc1
>
> Efficiency is computed as cpu seconds / throughput (one tcp_rr round trip).
> The following result shows efficiency delta before and after the patch
> series is applied.
If you don't mind, can you provide the exact cmd to run tcp_rr? Also am
I assuming correctly that you ran experiment in root container?
next prev parent reply other threads:[~2023-12-02 20:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 7:27 [PATCH v8 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption Coco Li
2023-11-29 7:27 ` [PATCH v8 net-next 1/5] Documentations: Analyze heavily used Networking related structs Coco Li
2023-11-30 10:37 ` Eric Dumazet
2023-12-02 20:00 ` Shakeel Butt
2023-11-29 7:27 ` [PATCH v8 net-next 2/5] cache: enforce cache groups Coco Li
2023-11-30 10:40 ` Eric Dumazet
2023-12-02 4:20 ` Jakub Kicinski
2023-12-02 20:08 ` Shakeel Butt
2023-11-29 7:27 ` [PATCH v8 net-next 3/5] netns-ipv4: reorganize netns_ipv4 fast path variables Coco Li
2023-11-30 10:48 ` Eric Dumazet
2023-12-02 20:23 ` Shakeel Butt
2023-11-29 7:27 ` [PATCH v8 net-next 4/5] net-device: reorganize net_device " Coco Li
2023-11-30 10:49 ` Eric Dumazet
2023-12-02 20:28 ` Shakeel Butt
2023-11-29 7:27 ` [PATCH v8 net-next 5/5] tcp: reorganize tcp_sock " Coco Li
2023-11-30 10:52 ` Eric Dumazet
2023-12-02 20:31 ` Shakeel Butt
2023-12-02 20:34 ` Shakeel Butt [this message]
2023-12-02 22:30 ` [PATCH v8 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption patchwork-bot+netdevbpf
2023-12-02 22:36 ` Neal Cardwell
2023-12-04 19:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231202203433.ifi6dn74hgnseq4y@google.com \
--to=shakeelb@google$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=daniel@iogearbox$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lixiaoyan@google$(echo .)com \
--cc=mubashirq@google$(echo .)com \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pnemavat@google$(echo .)com \
--cc=weiwan@google$(echo .)com \
--cc=wwchao@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox