Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command

From: Simon Horman <[email-masked]>
Date: Tue, 5 Dec 2023 20:33:12 +0000

On Wed, Nov 29, 2023 at 06:12:44PM +0100, Lorenzo Bianconi wrote:
> Introduce write_version netlink command similar to the ones available
> through the procfs.
> 
> Signed-off-by: Lorenzo Bianconi <[email-masked]>

...

> +/**
> + * nfsd_nl_version_get_doit - Handle verion_get dumpit

Hi Lorenzo,

a minor nit: this function is nfsd_nl_version_get_dumpit

> + * @skb: reply buffer
> + * @cb: netlink metadata and command arguments
> + *
> + * Returns the size of the reply or a negative errno.
> + */
> +int nfsd_nl_version_get_dumpit(struct sk_buff *skb,

...