Subject: Re: [PATCH net-next v3 4/7] net: wangxun: add ethtool_ops for ring parameters

From: Jakub Kicinski <[email-masked]>
Date: Wed, 6 Dec 2023 09:37:08 -0800

On Wed,  6 Dec 2023 17:53:52 +0800 Jiawen Wu wrote:
> +	ngbe_down(wx);
> +
> +	err = wx_set_ring(wx, new_tx_count, new_rx_count);
> +
> +	wx_configure(wx);
> +	ngbe_up(wx);

What if it fails? We don't allow down() / up() cycles on ethtool config
changes. You have to implement some form of reconfiguration, at minimum
it needs to be resilient to memory allocation failures (in which case
the old config should be kept and the device should keep running).