From: Jakub Kicinski <kuba@kernel•org>
To: Edward Cree <ecree.xilinx@gmail•com>
Cc: edward.cree@amd•com, linux-net-drivers@amd•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
netdev@vger•kernel.org, habetsm.xilinx@gmail•com,
sudheer.mogilappagari@intel•com, jdamato@fastly•com,
andrew@lunn•ch, mw@semihalf•com, linux@armlinux•org.uk,
sgoutham@marvell•com, gakula@marvell•com, sbhatta@marvell•com,
hkelam@marvell•com, saeedm@nvidia•com, leon@kernel•org
Subject: Re: [PATCH v4 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts
Date: Thu, 7 Dec 2023 08:45:06 -0800 [thread overview]
Message-ID: <20231207084506.727fc175@kernel.org> (raw)
In-Reply-To: <2ea45188-5554-8067-820d-378cada735ee@gmail.com>
On Thu, 7 Dec 2023 14:15:30 +0000 Edward Cree wrote:
> tl;dr: none of this is impossible, but it'd be a lot of work just to
> get rid of one mutex, and would paint us into a bit of a corner.
> So I propose to stick with the locking scheme for now; I'll post v5
> with the other review comments addressed; and if at some point in
> the future core tracking of ntuple filters gets added, we can
> revisit then whether moving to a replay scheme is viable. Okay?
Sounds good, thanks for investigating.
next prev parent reply other threads:[~2023-12-07 16:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 18:13 [PATCH v4 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2023-09-27 18:13 ` [PATCH v4 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2023-09-29 18:15 ` Jacob Keller
2023-10-02 9:59 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice edward.cree
2023-09-29 18:17 ` Jacob Keller
2023-10-04 22:56 ` Jakub Kicinski
2023-09-29 20:59 ` Mogilappagari, Sudheer
2023-10-02 10:23 ` Martin Habets
2023-10-04 23:00 ` Jakub Kicinski
2023-10-05 18:32 ` Edward Cree
2023-10-04 23:10 ` Jakub Kicinski
2023-10-05 18:43 ` Edward Cree
2023-10-05 23:53 ` Jakub Kicinski
2023-09-27 18:13 ` [PATCH v4 net-next 3/7] net: ethtool: record custom RSS contexts in the XArray edward.cree
2023-09-29 18:20 ` Jacob Keller
2023-10-02 10:41 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2023-09-29 18:23 ` Jacob Keller
2023-10-02 10:54 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2023-09-29 18:24 ` Jacob Keller
2023-10-02 12:13 ` Martin Habets
2023-09-27 18:13 ` [PATCH v4 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-09-29 18:27 ` Jacob Keller
2023-10-02 12:16 ` Martin Habets
2023-10-04 23:16 ` Jakub Kicinski
2023-10-05 20:56 ` Edward Cree
2023-10-06 0:07 ` Jakub Kicinski
2023-12-07 14:15 ` Edward Cree
2023-12-07 16:45 ` Jakub Kicinski [this message]
2023-09-27 18:13 ` [PATCH v4 net-next 7/7] sfc: use new rxfh_context API edward.cree
2023-09-29 18:27 ` Jacob Keller
2023-10-02 13:01 ` Martin Habets
2023-10-05 20:54 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207084506.727fc175@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=jdamato@fastly$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=sudheer.mogilappagari@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox